Skip to content

Conversation

@tjoyal
Copy link
Contributor

@tjoyal tjoyal commented Mar 12, 2024

This test fails.

# Failure:
# GraphQL::Schema::Warden::hiding fields#test_0003_hides directives if no other fields are using it
# Minitest::Assertion: --- expected
# +++ actual
# @@ -1 +1 @@
# -["include", "skip", "deprecated", "oneOf", "specifiedBy"]
# +["include", "skip", "deprecated", "oneOf", "specifiedBy", "cheremeDirectives"]

I believe that an "unused directive" shouldn't be added to the schema, similar to how it's done for unused (invisible) types.

Is this indeed the desired behavior as I'm assuming it should be?

I'm not sure I have the right expertise in the gem internals to propose an appropriate fix...

@rmosolgo
Copy link
Owner

Hey, thanks for pointing this out and sorry it took me so long to get to it. I'm working up a fix #5163, so I'll close this up.

@rmosolgo rmosolgo closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants