Allow accessing enum value names via methods

[DmitryTsepelev]

This is a pretty minor change, but might be helpful: now you can grab GraphQL name of the enum value using the method instead of a complex spell.

Before: Jazz::Family.values["STRING"].graphql_name
Now: Jazz::Family.string

[rmosolgo]

Hey, thanks so much for this contribution and sorry I didn't get back to you til now. I'm definitely open to this change. I think the next few things to work out are:

• What if the value's graphql_name.downcase conflicts with an existing method on Schema::Enum, like value, kind, or inherited? I think we should emit some kind of warning that the method generation was skipped and provide an override option like value_method:, whose value will be used instead of graphql_name.downcase.

• In case this causes some problems for people who are already using the gem, I'd like to have some way for them to turn it off. For example, if a value_method: option was added, value_method: false could disable creating these methods, and they could set that option by default in their base enum value classes.

Thanks, and let me know what you think!

[DmitryTsepelev]

Thanks for the feedback, I did my best to address everything! I also added a CI fix for unavailable Logger class

[rmosolgo]

Out of curiousity ... is this different than warn(...) ?

[DmitryTsepelev]

nope :)

[rmosolgo]

Thanks for this improvement!

[gmac]

For example, if a value_method: option was added, value_method: false could disable creating these methods, and they could set that option by default in their base enum value classes.

For future consideration, this should have been an opt-in rather than an opt-out, IMHO. Anything that adds strictly-convenience APIs with unlimited name cardinality to an existing schema structure should be done with care. This is particularly aggressive as a patch version change.

[rmosolgo]

Hey @gmac, sorry for the trouble with this. IMO it's not too late to make it opt-in. Could you describe the trouble you encountered?

[gmac]

We have a lot of superclassing over all major GraphQL structures to provide various internal concerns. It’s always a measured risk adding atop base library APIs, but they tend to evolve slowly and in isolated ways when they change in a conflicting manner. This change effectively created N new potentially conflicting APIs, where N is our own enum value surface area. I just overrode the enum constructor to disable the new methods everywhere, but it feels like that should have been the default.

[gmac]

I've opened this as a formal bug in #5254. This really should be off-by-default.