Fix a few minor issues in the Pagination Cursors guide#5556
Merged
rmosolgo merged 1 commit intormosolgo:masterfrom Feb 25, 2026
Merged
Conversation
duffuniverse
commented
Feb 25, 2026
|
|
||
| Now, all connections will use URL-safe base-64 encoding. | ||
|
|
||
| From a connection instance, the `cursor_encoders` methods are available via {{ "GraphQL::Pagination::Connection#encode" | api_doc }} and {{ "GraphQL::Pagination::Connection#decode" | api_doc }} |
Contributor
Author
There was a problem hiding this comment.
encode and decode are private methods
https://github.com/rmosolgo/graphql-ruby/blob/master/lib/graphql/pagination/connection.rb#L248-L254
They are not described in the API documentation https://graphql-ruby.org/api-doc/2.5.20/GraphQL/Pagination/Connection
Owner
|
Thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detail
Replace the API documentation link with the source code link in Pagination Cursors guide.