feat: Feature state - #3741
Closed
davor-bauk-sh wants to merge 1 commit into
Closed
feat: Feature state#3741davor-bauk-sh wants to merge 1 commit into
davor-bauk-sh wants to merge 1 commit into
Conversation
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
January 16, 2025 04:28 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
January 16, 2025 04:28 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
January 16, 2025 04:28 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
January 16, 2025 04:28 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
January 16, 2025 04:28 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
January 16, 2025 04:28 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
January 16, 2025 04:28 — with
GitHub Actions
Error
davor-bauk-sh
force-pushed
the
feature-state
branch
from
February 5, 2025 20:59
19a6b66 to
d8b5ba3
Compare
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 5, 2025 20:59 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 5, 2025 20:59 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 5, 2025 20:59 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 5, 2025 20:59 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 5, 2025 20:59 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 5, 2025 20:59 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 5, 2025 20:59 — with
GitHub Actions
Error
davor-bauk-sh
force-pushed
the
feature-state
branch
from
February 13, 2025 12:21
d8b5ba3 to
a286256
Compare
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 13, 2025 12:21 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 13, 2025 12:21 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 13, 2025 12:21 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 13, 2025 12:21 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 13, 2025 12:21 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 13, 2025 12:21 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 13, 2025 12:21 — with
GitHub Actions
Error
davor-bauk-sh
force-pushed
the
feature-state
branch
from
February 19, 2025 01:36
a286256 to
85e97a9
Compare
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 19, 2025 01:36 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 19, 2025 01:36 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 19, 2025 01:36 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 19, 2025 01:36 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 19, 2025 01:36 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 19, 2025 01:36 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 26, 2025 05:37 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 26, 2025 05:37 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 26, 2025 05:37 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 26, 2025 05:37 — with
GitHub Actions
Error
davor-bauk-sh
force-pushed
the
feature-state
branch
from
February 27, 2025 02:24
d1dfeb2 to
0ca3c6f
Compare
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 02:25 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 02:25 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 02:25 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 02:25 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 02:25 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 02:25 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 02:25 — with
GitHub Actions
Error
davor-bauk-sh
force-pushed
the
feature-state
branch
from
February 27, 2025 20:53
0ca3c6f to
50940a2
Compare
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 20:53 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 20:53 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 20:53 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 20:53 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 20:53 — with
GitHub Actions
Error
davor-bauk-sh
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2025 20:53 — with
GitHub Actions
Error
|
@mfazekas Is there a reason why this feature is not moved forward? It would be quite convenient in many different cases. Thank you :) |
Contributor
|
@davor-bauk-sh thanks much for looking into it, amazing work! Looks great for the first glance will be looking into it in details later this week. Sorry for the long turnaround |
Contributor
|
@davor-bauk-sh there are some android ci failures, you might need to rebase to/merge current main |
Contributor
Author
|
@mfazekas Rebased my branch on main. Hopefully CI will pass, otherwise I might need some help looking into the CI failures. |
Contributor
|
@davor-bauk-sh for some reason I wasn't able to get this working on this branch. I've needed to add v11 callback support, but otherwise it was working nice. It's merged now, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for setting, getting, and removing feature state (issue #1807).
Notes
I had trouble building the Android example project, which I solved by adding this to
/example/android/settings.gradle:Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
iOS:
feature-state-ios-oldarch-scaled.mp4
iOS (v11):
feature-state-ios-oldarch-v11-scaled.mp4
iOS (New Architecture):
feature-state-ios-newarch-scaled.mp4
iOS (v11, New Architecture):
feature-state-ios-newarch-v11-scaled.mp4
Android:
feature-state-oldarch-scaled.mp4
Android (v11):
feature-state-oldarch-v11-scaled.mp4
Android (New Architecture):
feature-state-newarch-scaled.mp4
Android (v11, New Architecture):
feature-state-newarch-v11-scaled.mp4