Skip to content

Commit

Permalink
[major] Drop support for Node.js < 4.5.0 (websockets#1313)
Browse files Browse the repository at this point in the history
  • Loading branch information
lpinca authored and 3rd-Eden committed Mar 4, 2018
1 parent 14538db commit 3f80ab7
Show file tree
Hide file tree
Showing 16 changed files with 1 addition and 42 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@ node_js:
- "8"
- "6"
- "4"
- "4.2.2"
after_success:
- "npm install coveralls@3 && nyc report --reporter=text-lcov | coveralls"
1 change: 0 additions & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ environment:
- nodejs_version: "8"
- nodejs_version: "6"
- nodejs_version: "4"
- nodejs_version: "4.2.2"
platform:
- x86
- x64
Expand Down
2 changes: 0 additions & 2 deletions bench/parser.benchmark.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
'use strict';

const safeBuffer = require('safe-buffer');
const benchmark = require('benchmark');
const crypto = require('crypto');

const WebSocket = require('..');

const Receiver = WebSocket.Receiver;
const Sender = WebSocket.Sender;
const Buffer = safeBuffer.Buffer;

const options = {
fin: true,
Expand Down
2 changes: 0 additions & 2 deletions bench/speed.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
'use strict';

const safeBuffer = require('safe-buffer');
const cluster = require('cluster');

const WebSocket = require('..');

const Buffer = safeBuffer.Buffer;
const port = 8181;

if (cluster.isMaster) {
Expand Down
4 changes: 0 additions & 4 deletions lib/buffer-util.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
'use strict';

const safeBuffer = require('safe-buffer');

const Buffer = safeBuffer.Buffer;

/**
* Merges an array of buffers into a new buffer.
*
Expand Down
4 changes: 0 additions & 4 deletions lib/constants.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
'use strict';

const safeBuffer = require('safe-buffer');

const Buffer = safeBuffer.Buffer;

module.exports = {
BINARY_TYPES: ['nodebuffer', 'arraybuffer', 'fragments'],
GUID: '258EAFA5-E914-47DA-95CA-C5AB0DC85B11',
Expand Down
3 changes: 0 additions & 3 deletions lib/permessage-deflate.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
'use strict';

const safeBuffer = require('safe-buffer');
const Limiter = require('async-limiter');
const zlib = require('zlib');

const bufferUtil = require('./buffer-util');
const constants = require('./constants');

const Buffer = safeBuffer.Buffer;

const TRAILER = Buffer.from([0x00, 0x00, 0xff, 0xff]);
const EMPTY_BLOCK = Buffer.from([0x00]);

Expand Down
3 changes: 0 additions & 3 deletions lib/receiver.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
'use strict';

const safeBuffer = require('safe-buffer');
const stream = require('stream');

const PerMessageDeflate = require('./permessage-deflate');
const bufferUtil = require('./buffer-util');
const validation = require('./validation');
const constants = require('./constants');

const Buffer = safeBuffer.Buffer;

const GET_INFO = 0;
const GET_PAYLOAD_LENGTH_16 = 1;
const GET_PAYLOAD_LENGTH_64 = 2;
Expand Down
3 changes: 0 additions & 3 deletions lib/sender.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
'use strict';

const safeBuffer = require('safe-buffer');
const crypto = require('crypto');

const PerMessageDeflate = require('./permessage-deflate');
const bufferUtil = require('./buffer-util');
const validation = require('./validation');
const constants = require('./constants');

const Buffer = safeBuffer.Buffer;

/**
* HyBi Sender implementation.
*/
Expand Down
3 changes: 0 additions & 3 deletions lib/websocket-server.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';

const safeBuffer = require('safe-buffer');
const EventEmitter = require('events');
const crypto = require('crypto');
const http = require('http');
Expand All @@ -11,8 +10,6 @@ const extension = require('./extension');
const constants = require('./constants');
const WebSocket = require('./websocket');

const Buffer = safeBuffer.Buffer;

/**
* Class representing a WebSocket server.
*
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
"lint": "eslint ."
},
"dependencies": {
"async-limiter": "~1.0.0",
"safe-buffer": "~5.1.0"
"async-limiter": "~1.0.0"
},
"devDependencies": {
"benchmark": "~2.1.2",
Expand Down
3 changes: 0 additions & 3 deletions test/permessage-deflate.test.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
'use strict';

const safeBuffer = require('safe-buffer');
const assert = require('assert');

const PerMessageDeflate = require('../lib/permessage-deflate');
const extension = require('../lib/extension');

const Buffer = safeBuffer.Buffer;

describe('PerMessageDeflate', function () {
describe('#offer', function () {
it('creates an offer', function () {
Expand Down
2 changes: 0 additions & 2 deletions test/receiver.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';

const safeBuffer = require('safe-buffer');
const assert = require('assert');
const crypto = require('crypto');

Expand All @@ -10,7 +9,6 @@ const Receiver = require('../lib/receiver');
const Sender = require('../lib/sender');

const kStatusCode = constants.kStatusCode;
const Buffer = safeBuffer.Buffer;

describe('Receiver', function () {
it('parses an unmasked text message', function (done) {
Expand Down
3 changes: 0 additions & 3 deletions test/sender.test.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
'use strict';

const safeBuffer = require('safe-buffer');
const assert = require('assert');

const PerMessageDeflate = require('../lib/permessage-deflate');
const Sender = require('../lib/sender');

const Buffer = safeBuffer.Buffer;

describe('Sender', function () {
describe('.frame', function () {
it('does not mutate the input buffer if data is `readOnly`', function () {
Expand Down
3 changes: 0 additions & 3 deletions test/websocket-server.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

'use strict';

const safeBuffer = require('safe-buffer');
const assert = require('assert');
const crypto = require('crypto');
const https = require('https');
Expand All @@ -12,8 +11,6 @@ const fs = require('fs');

const WebSocket = require('..');

const Buffer = safeBuffer.Buffer;

describe('WebSocketServer', function () {
describe('#ctor', function () {
it('throws an error if no option object is passed', function () {
Expand Down
3 changes: 0 additions & 3 deletions test/websocket.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

'use strict';

const safeBuffer = require('safe-buffer');
const assert = require('assert');
const crypto = require('crypto');
const https = require('https');
Expand All @@ -14,8 +13,6 @@ const os = require('os');
const constants = require('../lib/constants');
const WebSocket = require('..');

const Buffer = safeBuffer.Buffer;

class CustomAgent extends http.Agent {
addRequest () {}
}
Expand Down

0 comments on commit 3f80ab7

Please sign in to comment.