Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.7.0 #60

Merged
merged 7 commits into from
Aug 21, 2014
Merged

Release 0.7.0 #60

merged 7 commits into from
Aug 21, 2014

Conversation

jacobvosmaer
Copy link
Collaborator

No description provided.

@jacobvosmaer
Copy link
Collaborator Author

Ran bundle exec rake clean compile test against TagLib 1.7.2, 1.8 and 1.9.1 using Ruby 2.1.2 on OS X 10.9.

The gemspec check is clean; bundle exec rake install finishes clean.

## 0.7.0 (2014-08-09)

* Add support for TagLib::RIFF::AIFF (#52, by @tchev)
* Add support for TagLib::RIFF::WAV (#52, by @tchev)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, wrong PR number. Will fix.

@jacobvosmaer
Copy link
Collaborator Author

Next step: cross-compile for windows and test the windows gem.

@jacobvosmaer
Copy link
Collaborator Author

Could you assign the PR back to me when the windows build checks out @robinst ?

* Add support for TagLib::RIFF::WAV (#57, by @tchev)
* Associate filesystem encoding to filename strings
* Allow CXX override during gem installation
* Documentation updates
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you agree with this selection @robinst ; I made it looking at the list of closed PR's.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good way to look through the changes is this:

git log --first-parent v0.6.0..

Let's also add something about Heroku, maybe:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip! I added the heroku change.

@robinst
Copy link
Owner

robinst commented Aug 10, 2014

Nice work so far! Some things:

  • I created Regenerate SWIG wrappers using swig 2.0.12 #61 to regenerate the wrappers again. We should merge that and then rebase this release branch on it.
  • We should add @tchev to authors in taglib-ruby.gemspec, could you do that on your branch?
  • I added you as an owner to the gem, so you should be able to push the release to rubygems.org: https://rubygems.org/gems/taglib-ruby (I used your committer e-mail, hope that's the same you use on rubygems.org)

@jacobvosmaer
Copy link
Collaborator Author

I rebased on #61; tests still pass for TagLib 1.7.2, 1.8, 1.9.1.

@jacobvosmaer
Copy link
Collaborator Author

I signed into rubygems.org to check gem authorship; confirmed.

@jacobvosmaer
Copy link
Collaborator Author

Added @tchev to the authors in the gemspec.

@jacobvosmaer
Copy link
Collaborator Author

Back to you @robinst

@robinst
Copy link
Owner

robinst commented Aug 11, 2014

Made some progress for the binary gem today, see commits on master. Unfortunately, I ran into a problem, see rake-compiler/rake-compiler#95

@jacobvosmaer
Copy link
Collaborator Author

@robinst you are a brave man.

@robinst
Copy link
Owner

robinst commented Aug 12, 2014

Made some more progress, will test if the resulting gem works tomorrow.

@robinst
Copy link
Owner

robinst commented Aug 12, 2014

@robinst you are a brave man.

Haha, more like stubborn :).

@robinst
Copy link
Owner

robinst commented Aug 20, 2014

Ok, I didn't have any success, I say we release 0.7.0 without a Windows binary gem. I created #62 to track the problem.

So yeah, apart from that I'd say we're good for release. Update the date in CHANGES.md again and do it :).

jacobvosmaer added a commit that referenced this pull request Aug 21, 2014
@jacobvosmaer jacobvosmaer merged commit d03a5dd into master Aug 21, 2014
@jacobvosmaer
Copy link
Collaborator Author

@robinst
Copy link
Owner

robinst commented Aug 25, 2014

Yay :)! Any problems?

I updated the website: http://robinst.github.io/taglib-ruby/ Works nicely on mobile now thanks to Bootstrap 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants