bug: fixed bug where predictions was overwritten loosing data #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a logic error in predict() where tuple outputs from the model were converted to a dict before checking their length. As a result, the segmentation branch (len==3) was never reached and pred_masks were dropped.
AnonymDevOSS
requested review from
Matvezy,
SkalskiP,
isaacrob-roboflow and
probicheaux
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a logic error in predict() where tuple outputs from the model were converted to a dict before checking their length. As a result, the segmentation branch (len==3) was never reached and pred_masks were dropped.
Type of change
Please delete options that are not relevant.