Skip to content

Normalize Windows style paths to parse folder #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 28, 2025
Merged

Conversation

iurisilvio
Copy link
Contributor

@iurisilvio iurisilvio commented Apr 25, 2025

Description

Annotations are not uploaded because slashes don't match image filenames with our parse structure.

I'm forcing unix style slashes everywhere in folderparser.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

  • We have good tests for folderparser.
  • I tested to upload images from local mac.
  • I don't have a Windows to validate the fix. I'll ask the user to retry after release.

@iurisilvio iurisilvio requested a review from tonylampada April 25, 2025 10:07
@iurisilvio iurisilvio self-assigned this Apr 25, 2025
Copy link
Collaborator

@tonylampada tonylampada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic

@iurisilvio iurisilvio merged commit 33b2890 into main Apr 28, 2025
15 checks passed
@iurisilvio iurisilvio deleted the iuri/windows-2 branch April 29, 2025 10:05
@iurisilvio
Copy link
Contributor Author

Fix validated by user uploading annotations in Windows. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants