-
-
Notifications
You must be signed in to change notification settings - Fork 24
feat(robot): environment variable for load library timeout #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
environment variable for load library timeout
Linting fails due to violations already present in main unrelated to changes on this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces configurable timeout for library loading through environment variables and standardizes timeout constant naming. The main purpose is to allow users to customize the timeout for loading libraries via the ROBOTCODE_LOAD_LIBRARY_TIMEOUT
environment variable, addressing issue #505.
Key changes:
- Added environment variable support for
LOAD_LIBRARY_TIMEOUT
configuration - Renamed timeout constants from
TIME_OUT
toTIMEOUT
for consistency - Enhanced error messages to include timeout information and configuration guidance
Sorry—I know you’ve already put a lot of work into it. But depending on how you want to submit it—either as a single patch or as individual commits—you should follow the Contributing Guide, sign your commits, and adhere to the Conventional Commits rules. If you want to leave it as is, I can only create a patch and apply it; you’ll of course be credited as a co-author, but then it won’t be clear which parts of the code you wrote. |
Closes #505
Environment variables don't seem to be documented, hence I did not start documenting.
Also renamed the other constants in the file (
TIMEOUT
instead ofTIME_OUT
).Details:
Configure
LOAD_LIBRARY_TIMEOUT
with environment variableROBOTCODE_LOAD_LIBRARY_TIMEOUT