Skip to content

Conversation

Noordsestern
Copy link
Member

Closes #505

Environment variables don't seem to be documented, hence I did not start documenting.

Also renamed the other constants in the file (TIMEOUT instead of TIME_OUT).

Details:

Configure LOAD_LIBRARY_TIMEOUT with environment variable ROBOTCODE_LOAD_LIBRARY_TIMEOUT

environment variable for load library timeout
Copy link

github-actions bot commented Sep 9, 2025

Test Results

    112 files  ±0      112 suites  ±0   1h 6m 40s ⏱️ -46s
  1 838 tests ±0    1 838 ✅ ±0  0 💤 ±0  0 ❌ ±0 
205 856 runs  ±0  205 856 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c69e5a3. ± Comparison against base commit a6ffcf5.

♻️ This comment has been updated with latest results.

@Noordsestern Noordsestern changed the title feat: core: environment variable for load library timeout feat(core): environment variable for load library timeout Sep 10, 2025
@Noordsestern
Copy link
Member Author

Linting fails due to violations already present in main unrelated to changes on this branch.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces configurable timeout for library loading through environment variables and standardizes timeout constant naming. The main purpose is to allow users to customize the timeout for loading libraries via the ROBOTCODE_LOAD_LIBRARY_TIMEOUT environment variable, addressing issue #505.

Key changes:

  • Added environment variable support for LOAD_LIBRARY_TIMEOUT configuration
  • Renamed timeout constants from TIME_OUT to TIMEOUT for consistency
  • Enhanced error messages to include timeout information and configuration guidance

@d-biehl
Copy link
Member

d-biehl commented Sep 11, 2025

Sorry—I know you’ve already put a lot of work into it. But depending on how you want to submit it—either as a single patch or as individual commits—you should follow the Contributing Guide, sign your commits, and adhere to the Conventional Commits rules. If you want to leave it as is, I can only create a patch and apply it; you’ll of course be credited as a co-author, but then it won’t be clear which parts of the code you wrote.

@d-biehl d-biehl changed the title feat(core): environment variable for load library timeout feat(robot): environment variable for load library timeout Sep 11, 2025
@d-biehl d-biehl merged commit 3d64dca into main Sep 11, 2025
120 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Publish LOAD_LIBRARY_TIME_OUTas environment variables
2 participants