-
Notifications
You must be signed in to change notification settings - Fork 7
All the offseason changes put together. #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…o SoloController
…what is the closest algae
… into cyclesuper
} | ||
|
||
// if the solo controller is connected, use it for driving | ||
boolean soloCC = soloController.isConnected(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will result in soloCC
only being set when the robot code starts running, so changing to or from soloCC will require a restart of the robot code. Consider instead making this a boolean class member variable and then updating it ever second or so based on whether the solo controller is connected (via adding a new update
method in this class that Robot.robotPeriodic()
calls, and have the update
method do the soloCC update every second or so).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it worked fine at drive practice we can check again at the meeting on monday
-Aarya (I forgot what account im on)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it actually matter is we just call soloController.isConnected() instead of soloCC for the drive request (changing it back to what is was before)?
No description provided.