fix(ui): improve budget KPI card labels and arrow directions#32
Merged
Conversation
- Actual Expenses: show "$X over budget" in red when over, keep "$X remaining" in green when under - Actual Income: change "remaining" to "under budget" when below target Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add trendDirection prop to KPICard to decouple arrow direction from color. Expenses under budget show green with arrow down, over budget shows red with arrow up. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the budget page KPI cards to show more accurate labels and correct arrow directions for expense tracking.
Changes
KPICard component
trendDirectionprop to decouple arrow direction from color (trendcontrols color,trendDirectioncontrols the arrow)trendwhentrendDirectionis not provided (backward compatible)BudgetPage