fix(import): remember manually flagged transfers, improve detection, add zebra striping#37
Merged
Merged
Conversation
- Check ALL rows against dismissed transfers list, not just auto-detected ones. Previously, manually flagged transfers were dismissed on import but not recognized on reimport because only auto-detected transfers were checked against the dismissed list. - Add RTP, incoming/outgoing payment patterns to transfer detector - Handle 'PaymentROBERT' (no space) via lookahead regex - Add alternating row colors (zebra striping) to import tables Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use \bpayment (no trailing boundary) to match both standalone 'payment' and conjoined forms like 'PaymentJOHN', 'PaymentSARAH', etc. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…list - Remove checkboxes from dismissed transfer sections (both CSV and bank sync) - Add clickable 'Transfer ✕' badge to every dismissed row - Clicking removes transfer flag and isDismissedTransfer, moves row to main list - Auto-selects the row when moved back to main list - ImportPage toggleTransferFlag now clears isDismissedTransfer too Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Manually flagged transfers forgotten on reimport
The dismissed transfer check only ran against auto-detected transfers. On reimport, manually flagged transfers from the previous session weren't recognized because the server's auto-detection didn't catch them. Now ALL rows are checked against the dismissed list, so both auto-detected and manually flagged transfers are remembered.
"RTP Incoming Payment" not detected as transfer
Added new transfer detection patterns:
\brtp\b— Real-Time Payment\bincoming payment/\boutgoing payment\bpayment(?=[A-Z])— handles "PaymentROBERT" (no space between payment and name)Alternating row colors
Added subtle zebra striping (
--bg-zebraCSS variable) to both CSV import and bank sync tables for better visual row distinction. Respects existing conditional backgrounds (needs-attention, unselected opacity).