Skip to content

Commit

Permalink
fixed label guess
Browse files Browse the repository at this point in the history
  • Loading branch information
Avi-Robusta committed Jan 26, 2025
1 parent 095fe91 commit 59a9735
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
9 changes: 7 additions & 2 deletions src/robusta/core/discovery/top_service_resolver.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,15 @@ def guess_cached_resource(cls, name: str, namespace: str) -> Optional[TopLevelRe

@classmethod
def guess_workload_from_labels(cls, labels: Dict[Any, Any] = None) -> Optional[TopLevelResource]:
if not labels or "namespace" not in labels:
return None
namespace = labels["namespace"]
relevant_label_keys = ["job_name", "deployment", "statefulset", "daemonset", "pod"]
for label in relevant_label_keys:
if label in labels:
return labels[label]
if not label in labels:
continue
cls.guess_cached_resource(name=labels[label], namespace=namespace)
return labels[label]
return None

@classmethod
Expand Down
1 change: 1 addition & 0 deletions src/robusta/core/reporting/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ def __init__(
self.enrichments: List[Enrichment] = []
self.links: List[Link] = []
self.service = TopServiceResolver.guess_cached_resource(name=subject.name, namespace=subject.namespace)
# this is only used by the slack sink in the case that self.service is None, like if the recourse is deleted
self.backup_workload_name = TopServiceResolver.guess_workload_from_labels(labels=silence_labels)
self.service_key = self.service.get_resource_key() if self.service else ""
uri_path = f"services/{self.service_key}?tab=grouped" if self.service_key else "graphs"
Expand Down

0 comments on commit 59a9735

Please sign in to comment.