Report lacking to while parsing app header
#6105
Merged
+100
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for helping out @caryoscelus! Could you add a test for this as well? |
Contributor
Author
|
@Anton-4 sure! it seems there's also a lot of space to lower code repetition while i'm at it |
caryoscelus
force-pushed
the
app-provides-error-reporting
branch
from
3929dd6 to
3332503
Compare
Contributor
Author
on second thought, probably condensing code isn't worth here @Anton-4 ready for review |
Signed-off-by: Anton-4 <17049058+Anton-4@users.noreply.github.com>
Signed-off-by: Anton-4 <17049058+Anton-4@users.noreply.github.com>
Anton-4
approved these changes
Nov 28, 2023
Collaborator
Anton-4
left a comment
Anton-4
left a comment
There was a problem hiding this comment.
Looks good, thanks @caryoscelus!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.