Skip to content

Cleanup Examples folder #7401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 8, 2025
Merged

Cleanup Examples folder #7401

merged 9 commits into from
Jan 8, 2025

Conversation

lukewilliamboswell
Copy link
Collaborator

This PR

@Anton-4 Anton-4 changed the title Cleanup Examples folder DO NOT MERGE Cleanup Examples folder Dec 23, 2024
@Anton-4
Copy link
Collaborator

Anton-4 commented Dec 23, 2024

This is going to break the nightly testing, let's merge this sometime after the next basic-cli release.

@lukewilliamboswell lukewilliamboswell changed the title DO NOT MERGE Cleanup Examples folder Cleanup Examples folder Jan 5, 2025
Anton-4
Anton-4 reviewed Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be good to merge once the test failures are addressed.

@lukewilliamboswell lukewilliamboswell merged commit 3e0c626 into main Jan 8, 2025
19 checks passed
@lukewilliamboswell lukewilliamboswell deleted the cleanup-examples branch January 8, 2025 09:30
@smores56 smores56 mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-4 Anton-4 Anton-4 left review comments

@smores56 smores56 smores56 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukewilliamboswell @Anton-4 @smores56