Zero arg syntax #7529
Draft
Zero arg syntax #7529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you post the compiler errors and/or runtime errors you are getting? |
|
I'd probably suggest adding some |
|
I added two very basic |
|
The simplest test: |
|
The above seems closer to the real problem, but there are plenty of alias analysis problems as well. Here's one from a |
Did you try running this with |
|
The error is definitely coming from Morphic |
|
The relevant part of the program that fails: |
|
It seems this is interesting: Let(
`#UserApp.var`,
Struct(
[],
),
InLayout(
23,
),
Ret(
`#UserApp.var`,
),
),
``` |
|
There would be a |
|
Here's the value def coming into can: |
|
After canonicalizing the pending_value_def: |
|
I think that creates/compiler/mono/src/ir.rs:8179 is an interesting thing to checkout. We apparently create a closure for imported functions (that have no fields because there is no capture needed). And then we don't do normal things with that closure afterwards (like call the function with it) |
|
But I have no idea. Somewhere this gets changed and I can't find it |
|
So I've tracked this down to what should be obvious, the layout representation for the lambda set is Struct, with zero fields. But I need to see what's different about have a single arg to figure out what we aren't doing. |
|
After edited your example so that the function called from main has a single arg and comparing the output, I see this. mono/src/ir.rs (call_by_name_help): } else if field_symbols.is_empty() { // <- Zero args hits this, it thinks we are just assigning a func/closure to a var
println!("field_symbols is empty");
// this is a case like `Str.concat`, an imported standard function, applied to zero arguments
// imported symbols cannot capture anything
let captured = &[];
debug_assert!(proc_name.no_captures());
construct_closure_data(
env,
procs,
layout_cache,
lambda_set,
proc_name,
captured,
assigned,
hole,
)
} else {
println!("None of the above"); // <- A single arg hits this. it recognizes that this is an actual call.
debug_assert_eq!(
argument_layouts.len(),
field_symbols.len(),
"see call_by_name for background (scroll down a bit), function is {proc_name:?}",
);
let field_symbols = field_symbols.into_bump_slice();
let call = self::Call {
call_type: CallType::ByName {
name: proc_name,
ret_layout,
arg_layouts: argument_layouts,
specialization_id: env.next_call_specialization_id(),
},
arguments: field_symbols,
};
let result = build_call(env, call, assigned, ret_layout, hole);
let iter = loc_args.into_iter().rev().zip(field_symbols.iter().rev());
assign_to_symbols(env, procs, layout_cache, iter, result)
} |
|
The fix: Now, I'm not certain this is IT. But it does solve this test case.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An in-progress change for my work to support zero-argument functions in userspace for Roc.