[zig] Parser: Add Region to node #7687
Conversation
| node.tag = .decl; | ||
| node.data.lhs = d.pattern.id; | ||
| node.data.rhs = d.body.id; | ||
| node.region = d.region; | ||
| }, | ||
| .expr => |expr| { | ||
| node.tag = .expr; | ||
| node.data.lhs = expr.expr.id; | ||
| node.region = expr.region; | ||
| }, | ||
| .crash => |c| { | ||
| node.tag = .crash; | ||
| node.data.lhs = c.expr.id; | ||
| node.region = c.region; | ||
| }, | ||
| .expect => |e| { | ||
| node.tag = .expect; | ||
| node.data.lhs = e.body.id; | ||
| node.region = e.region; | ||
| }, | ||
| .@"return" => |r| { | ||
| node.tag = .@"return"; | ||
| node.data.lhs = r.expr.id; | ||
| node.region = r.region; | ||
| }, | ||
| .import => |i| { | ||
| node.tag = .import; | ||
| node.region = i.region; | ||
| node.main_token = i.module_name_tok; | ||
| var rhs = ImportRhs{ | ||
| .aliased = 0, |
There was a problem hiding this comment.
Aren't all of these regions missing the body?
Like the region for return x should include the entire return x, no just be the region of the return token?
Though maybe I am missing something, I just don't see anything aggregating regions.
| while (self.peek() != .CloseSquare and self.peek() != .EndOfFile) { | ||
| self.advance(); | ||
| } | ||
| self.expect(.CloseSquare) catch {}; | ||
| self.store.clearScratchExposedItemsFrom(scratch_top); | ||
| return self.pushMalformed(IR.NodeStore.HeaderIdx, .import_exposing_no_close); | ||
| return self.pushMalformed(IR.NodeStore.HeaderIdx, .import_exposing_no_close, start); |
There was a problem hiding this comment.
Can we name the malformed regions better? start suggest that a malformed node is always a single character and never has a true region.
@bhansconnect I agree with this... though I think we might want to do that in a follow up. I've experimented with it some and I think we have some issues with regions we need to shake out and it will be much easier if we can land this and my PR (with the snapshot improvements) and we have much better debug information. |
|
@bhansconnect I am learning about mismatches in regions right now doing multiline stuff I actually meant to mark this as DO NOT MERGE, but that's my bad. |
Adds the Region struct to all nodes. Needed for error reporting, and making formatting work correctly.