Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove || and && from tokenizer #7689

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

bhansconnect
Copy link
Member

As discussed here: https://roc.zulipchat.com/#narrow/channel/395097-compiler-development/topic/zig.20compiler.20-.20spike/near/504579627

I assume in the long term, support will be added to the parser to notice when double opBar or opAmpersand should be consider an and or or. Then the formatter will fix things up.

For now, double bar is always a lambda and double ampersand is invalid.

@bhansconnect bhansconnect enabled auto-merge March 11, 2025 16:21
As discussed here: https://roc.zulipchat.com/#narrow/channel/395097-compiler-development/topic/zig.20compiler.20-.20spike/near/504579627

I assume in the long term, support will be added to the parser
to notice when double opBar or opAmpersand should be consider an `and` or `or`.
Then the formatter will fix things up.

For now, double bar is always a lambda and double ampersand is invalid.
@bhansconnect bhansconnect force-pushed the bhansconnect/push-lwtzwqxlnrls branch from 65dc02a to 5199cda Compare March 11, 2025 16:25
@bhansconnect bhansconnect merged commit 76b5ed2 into main Mar 11, 2025
18 checks passed
@bhansconnect bhansconnect deleted the bhansconnect/push-lwtzwqxlnrls branch March 11, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants