Remove || and && from tokenizer
#7689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed here: https://roc.zulipchat.com/#narrow/channel/395097-compiler-development/topic/zig.20compiler.20-.20spike/near/504579627 I assume in the long term, support will be added to the parser to notice when double opBar or opAmpersand should be consider an `and` or `or`. Then the formatter will fix things up. For now, double bar is always a lambda and double ampersand is invalid.
bhansconnect
force-pushed
the
bhansconnect/push-lwtzwqxlnrls
branch
from
65dc02a to
5199cda
Compare
lukewilliamboswell
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: https://roc.zulipchat.com/#narrow/channel/395097-compiler-development/topic/zig.20compiler.20-.20spike/near/504579627
I assume in the long term, support will be added to the parser to notice when double opBar or opAmpersand should be consider an
andoror. Then the formatter will fix things up.For now, double bar is always a lambda and double ampersand is invalid.