Expand roc format to support directories #7703
Conversation
| /// Formats all roc files in the specified path. | ||
| /// Handles both single files and directories | ||
| /// Returns the number of files formatted. | ||
| pub fn formatPath(gpa: std.mem.Allocator, base_dir: std.fs.Dir, path: []const u8) !usize { |
There was a problem hiding this comment.
Not important to integrate with yet, but we have a half-baked filesystem wrapper that will help us with supporting WASI and maybe testing. That would probably be good to discuss the merits of in Zulip before we get too far.
There was a problem hiding this comment.
To note, this isn't really changed. I just moved this code. But I agree we should fix it up.
src/fmt.zig
Outdated
| for (parse_ast.errors) |err| { | ||
| try stderr.print("\t{s}\n", .{@tagName(err.tag)}); | ||
| } | ||
| fatal("\n", .{}); |
There was a problem hiding this comment.
Based on what I see in the old compiler, this "exit on malformed code" seems to mostly match our current behavior, but I don't know if it's desired to fail if there are literally any parsing problems. What if there's a single unfinished function body, but everything else is valid?
Did I miss a discussion on whether this was what we wanted? It's fine for now, but we'll want to make sure we align here at some point.
There was a problem hiding this comment.
Long term the goal is that most errors will be recoverable and get formatted. For now, that is not anywhere near the case. So we just fail.
|
I'll make a follow up tomorrow |
|
@bhansconnect Looks good! Would you mind writing some tests? |
I don't think we have a good way to test this until we have proper mocks for the filesystem. That or at a minimum we need to spin up a proper temp directory. The current test generates a file in the roc project folder. I don't want to make more tests like that. |
|
Haha, tests are hanging cause you are not allowed to print to I forgot this was a restriction of |
bhansconnect
force-pushed
the
bhansconnect/push-lqvyptntrtqs
branch
3 times, most recently
from
c4f86b4 to
b923627
Compare
Also supports formatting multiple passed in args. Also prints the overall execution time.
bhansconnect
force-pushed
the
bhansconnect/push-lqvyptntrtqs
branch
from
b923627 to
68dfd00
Compare
Also supports formatting multiple passed in args.
Also prints the overall execution time.