- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 349
 
Upgrade to zig 0.15.2 #8238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            Upgrade to zig 0.15.2 #8238
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …riter instead of writer
…riter instead of writer
abf5810    to
    208a6ac      
    Compare
  
    208a6ac    to
    a0f05d0      
    Compare
  
    
          
  | 
    
Fixes for upgrade to zig 0.15.1
              
                    Anton-4
  
              
              approved these changes
              
                  
                    Oct 19, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
My default approach has been to make the smallest possible changes to keep the risk of introducing bugs low. Then we can come back around later and fully migrate to the new APIs with a fully working build and an easier time testing. For example, I've chosen to use
.deprecatedWriter()whenever possible here rather than migrating to the newstd.io.Writerinterface everywhere in one go.I haven't landed in a good spot yet with bundle/unbundle, so if someone else takes a look at this, you might want to forget about those commits and start fresh. The chains of readers and writers make things more difficult, and some old APIs have been completely changed/removed rather than deprecated like the old buffered writer and the old tar writer.