Skip to content

simplify tree "rebalancing" - #43

Open
doudou wants to merge 1 commit into
masterfrom
simplify_loop_handling
Open

simplify tree "rebalancing"#43
doudou wants to merge 1 commit into
masterfrom
simplify_loop_handling

Conversation

@doudou

@doudou doudou commented Jun 25, 2019

Copy link
Copy Markdown
Member

We now unconditionally ensure that the graph is a tree (as it should),
by always removing the parent from the target node, and reconnecting
said node to the new transformation.

The very complex implementation currently there did not seem to be needed.

We now unconditionally ensure that the graph is a tree (as it should),
by always removing the parent from the target node, and reconnecting
said node to the new transformation.

The very complex implementation currently there did not seem to be needed.
@doudou
doudou force-pushed the simplify_loop_handling branch from dc9f56c to a4646ee Compare June 25, 2019 12:43
@arneboe

arneboe commented Jun 25, 2019

Copy link
Copy Markdown
Contributor

My new test-case works but now some of the old ones fail.

testTransformerGraph.cpp(149): fatal error: in "vizkit3d_TransformerGraph/it_appends_new_edges_to_the_existing_graph": critical check it != description.end() has failed
testTransformerGraph.cpp(149): fatal error: in "vizkit3d_TransformerGraph/it_automatically_changes_the_node_shape_when_needed": critical check it != description.end() has failed
testTransformerGraph.cpp(138): fatal error: in "vizkit3d_TransformerGraph/it_handles_loops_gracefully_when_reshaping": critical check description.size() == expected_graph_size has failed [1 != 4]

@planthaber

Copy link
Copy Markdown
Member

This has not been merged?

@doudou

doudou commented Jan 27, 2021

Copy link
Copy Markdown
Member Author

No, since there are some tests that are not passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants