Skip to content

chore: remove dependency on the orocos.toolchain package set #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: remove dependency on the orocos.toolchain package set #250

wants to merge 2 commits into from
+127 −69

Conversation

doudou
Copy link
Member

@doudou doudou commented Mar 21, 2025

No description provided.

@doudou
fix: do not force-add the 'stable' tag to rtt
cad4ee0 
It's in the manifest, there's no reason to force it in the ruby code
@doudou doudou force-pushed the remove_orocos_toolchain branch from edaab4c to 8866203 Compare March 21, 2025 16:45
pierrewillenbrockdfki
pierrewillenbrockdfki reviewed May 20, 2025
View reviewed changes
Copy link
Contributor

@pierrewillenbrockdfki pierrewillenbrockdfki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are packages in rock.core that require ruby-dev from orocos.toolchain(binding_of_caller, rice, thin, qtruby, concurrent-ruby). You probably want to move the osdep definition of ruby-dev in here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrewillenbrockdfki pierrewillenbrockdfki pierrewillenbrockdfki left review comments

@jhonasiv jhonasiv jhonasiv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doudou @pierrewillenbrockdfki @jhonasiv