Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new pages for Dev Container (Features / Images / Templates) #84

Merged
merged 15 commits into from
Nov 17, 2022

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Nov 11, 2022

close #77
related to rocker-org/devcontainer-features#74
related to rocker-org/devcontainer-templates#3

By the way, I tried to do all this PR work in Codespaces (transfer to VSCode on my local computer).
I had no problems at all working while doing quarto preview, which convinced me that this will be widely used in the future.

@eitsupi eitsupi marked this pull request as ready for review November 12, 2022 16:02
@eitsupi
Copy link
Member Author

eitsupi commented Nov 15, 2022

@cboettig @eddelbuettel Sorry for the large volume, but could you please check this?
I want to help users who want to use R in Codespaces.

[*.md]
indent_style = space
indent_size = 4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to complains about line breaks in the listings, such as the following:

- item1
  item1 <- linter complains this line with this setting.
- item2

Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some quick comments.

@eitsupi
Copy link
Member Author

eitsupi commented Nov 15, 2022

Thanks for your comments!

I have created a new issue #85 about Posit and would like to address the pages outside of this PR in #85.

@eitsupi eitsupi merged commit 6b24de4 into rocker-org:master Nov 17, 2022
@eitsupi eitsupi deleted the dev-container branch November 17, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new pages for Dev Container (Features)
2 participants