Skip to content

Adjust the punctuation marks #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2025
Merged

Adjust the punctuation marks #2735

merged 6 commits into from
Jun 16, 2025

Conversation

jimcat8
Copy link
Contributor

@jimcat8 jimcat8 commented Jun 8, 2025 •
edited by sspencerwire
Loading

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

sspencerwire
sspencerwire reviewed Jun 8, 2025
View reviewed changes
docs/books/admin_guide/11-tasks.md
@@ -147,14 +147,14 @@ Example:
|--------|-----------------------------------------------------------|
| `-e` | Edits the schedule file with vi |
| `-l` | Displays the contents of the schedule file |
| `-u` | Sets the name of the user whose schedule file is to be manipulated |
| `-u <user>` | Specify a single user to operate |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good.

sspencerwire
sspencerwire reviewed Jun 8, 2025
View reviewed changes
docs/books/admin_guide/11-tasks.md
| `-r` | Deletes the schedule file |

!!! Warning

`crontab` without options deletes the old schedule file and waits for the user to enter new lines. You have to press <kbd>ctrl</kbd> + <kbd>d</kbd> to exit this editing mode.

Only the `root` can use the `-u user` option to manage another user's schedule file.
Only the `root` can use the `-u <user>` option to manage another user's schedule file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fine with this change.

sspencerwire
sspencerwire reviewed Jun 8, 2025
View reviewed changes
docs/books/admin_guide/11-tasks.md
| `/` | Defines a step |
| `*` | Indicates all the time values of the field |
| `-` | Indicates a continuous time range |
| `,` | Indicates the discontinuous time range |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean "Indicates a non-contiguous time range" rather than "discontinuous"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean "Indicates a non-contiguous time range" rather than "discontinuous"

It seems that native speakers may also confuse the usage of these two words

sspencerwire
sspencerwire reviewed Jun 11, 2025
View reviewed changes
docs/books/admin_guide/11-tasks.md Outdated
@@ -254,12 +254,12 @@ For the root user, `crontab` also has some special time settings:

A user, rockstar, wants to edit his `crontab` file:

1. `crond` checks to see if he is allowed (`/etc/cron.allow` and `/etc/cron.deny`).
1. The `crond` daemon checks to see if he is allowed (`/etc/cron.allow` and `/etc/cron.deny`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pronoun "he" should not be used. I realize that you are editing the document and "he" was already there. This should be a generic pronoun or reworded. In this case, the sentence should be: "The crond daemon checks to see if the user is allowed (/etc/cron.allow and /etc/cron.deny).

docs/books/admin_guide/11-tasks.md
@@ -254,12 +254,12 @@ For the root user, `crontab` also has some special time settings:

A user, rockstar, wants to edit his `crontab` file:

1. `crond` checks to see if he is allowed (`/etc/cron.allow` and `/etc/cron.deny`).
1. The `crond` daemon checks to see if he is allowed (`/etc/cron.allow` and `/etc/cron.deny`).

2. If he is, he accesses his `crontab` file (`/var/spool/cron/rockstar`).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this would be: "2. If the user is allowed, they access their crontab file (/var/spool/cron/rockstar).

docs/books/admin_guide/11-tasks.md Outdated

2. If he is, he accesses his `crontab` file (`/var/spool/cron/rockstar`).

Every minute `crond` reads the schedule files.
The `crond` daemon reads the scheduled task files of all users every minute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think this needs to be redone too. First of all, you don't want the procedure to repeat "The crond daemon..." when you can add this to 2: "The crond daemon:" Followed by:
3. Reads the scheduled task files of all users every minute
4. Runs tasks according to the schedule (no need for the last part-no need to say it is for this particular user, because that is assumed from step 1)
5. Writes the corresponding events and messages to the (/var/log/cron) file

@github-actions GitHub Actions
Copy link

Test results for 9ac2b46:

Number of broken URLs: 3

 
URL,RESULT,FILENAME
 http://$(hostname):8080,failed,guides/repositories/pulp_fetch_upload.md
 https://www.ssllabs.com/ssltest/,failed,guides/web/caddy.md
 https://ftp.gnu.org/gnu/hello/hello-2.12.tar.gz,failed,labs/systems_administration_I/lab7-software_management.md

@sspencerwire sspencerwire merged commit 1763821 into rocky-linux:main Jun 16, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspencerwire sspencerwire sspencerwire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimcat8 @sspencerwire