Skip to content

feat: consolidate repository quality and diagnostics improvements - #192

Merged
rodri-oliveira-dev merged 11 commits into
mainfrom
feat/repository-quality-consolidation
Oct 18, 2026
Merged

rodri-oliveira-dev merged 11 commits into
mainfrom
feat/repository-quality-consolidation

Conversation

@rodri-oliveira-dev

Copy link
Copy Markdown
Owner

Problem

The repository presented conflicting component publication status, its distribution policy could miss newly added Marketplace workflows or accept an unrelated retention marker, and relationship diagnostics did not preserve locations already known by the parser. These changes were previously split across #189, #190, and #191, which made their shared compatibility evidence and review fixes harder to assess together.

Solution

  • align the English and pt-BR README, support, security, compatibility, release, MCP, and portal documentation with the verified independent distribution status of CLI 1.8.0, MCP 1.0.0, Marketplace extension 1.0.1, and VSIX candidate 1.1.0;
  • validate component versions and distribution states without coupling their release numbers;
  • enforce 21-day retention on the actual VSIX upload steps and reject Marketplace publishing indicators in every workflow;
  • refresh the pinned .NET runtime image to the patched 10.0.2 digest;
  • add optional line and column fields to validation JSON and SARIF diagnostics, preserving compatibility and the existing fallback for unknown locations;
  • propagate parser-backed locations through relationship findings and navigate to them from the VS Code Problems view;
  • document the current CLI/MCP project relationship and the evidence-based decision to defer a shared-library extraction.

This PR supersedes #189, #190, and #191 and includes fixes for every substantive review thread raised on those PRs.

Relevant files

  • README.md, README.pt-BR.md, SECURITY.md, SUPPORT.md, docs/compatibility*.md, and release documentation
  • scripts/component-distribution-policy-test.sh and distribution workflows
  • src/AdrGuard/Validation, validation output models/renderers, and JSON/SARIF schemas
  • extensions/vscode/src, its contract fixtures, and integration tests
  • docs/architecture/component-boundaries*.md

Compatibility

Existing commands, configuration, exit codes, schema versions, and required fields remain unchanged. Diagnostic line and column fields are optional and omitted when no reliable source location exists. The extension retries older CLIs that do not support diagnostic locations. Component versions remain independent, and Marketplace publishing stays disabled.

Validation

  • dotnet restore AdrGuard.slnx
  • dotnet build AdrGuard.slnx --configuration Release --no-restore — 0 warnings, 0 errors
  • dotnet test --solution AdrGuard.slnx --configuration Release --no-build — 695 passed
  • focused relationship validation tests — 11 passed
  • VS Code npm ci, lint, typecheck, unit, extension-host, multi-root, restricted-workspace, and README-image checks — 115 unit tests passed, 1 expected platform skip, 17 host tests passed
  • website npm ci, npm run sync:docs, npm run validate, and npm run test:spelling — 116 pages built, 46 bilingual routes, 0 spelling issues
  • scripts/component-distribution-policy-test.sh plus negative mutations for decoy retention and a newly added Marketplace workflow
  • git diff --check

Risks

The workflow policy intentionally uses conservative text checks and can require an update when GitHub Marketplace publication mechanisms change. Precise locations are emitted only where the parser has evidence; findings without evidence keep the established file-level fallback.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T18:04:56.371152Z c97de4f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b213e9245

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/component-distribution-policy-test.sh Outdated
Comment thread extensions/vscode/src/validation/diagnostics.ts
@rodri-oliveira-dev

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75279457d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/component-distribution-policy-test.sh Outdated
Comment thread scripts/component-distribution-policy-test.sh Outdated
@rodri-oliveira-dev

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c73d124644

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/component-distribution-policy-test.sh Outdated
Comment thread scripts/component-distribution-policy-test.sh Outdated
@rodri-oliveira-dev

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48219572a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/component-distribution-policy-test.sh
@rodri-oliveira-dev

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b0b12c82b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/component-distribution-policy-test.sh Outdated
Comment thread scripts/component-distribution-policy-test.sh Outdated
Comment thread docs/cli-reference.md
@rodri-oliveira-dev

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c97de4f48d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/component-distribution-policy-test.sh
Comment thread scripts/component-distribution-policy-test.sh Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant