Skip to content

Status: only create User and Group when requested#183

Closed
simeonschaub wants to merge 1 commit intorofinn:masterfrom
simeonschaub:patch-1
Closed

Status: only create User and Group when requested#183
simeonschaub wants to merge 1 commit intorofinn:masterfrom
simeonschaub:patch-1

Conversation

@simeonschaub
Copy link
Contributor

Potential fix for #182

@rofinn
Copy link
Owner

rofinn commented Jan 31, 2025

Hmm, the problem with just pushing this to getproperty is that you're potentially adding unnecessary work on duplicate accesses (e.g., print, string). I think a better approach might be to:

  1. Correct the system path behavior to just call Mode(stat(string(fp)).mode)
  2. Add additional error handling to libc and maybe a feature flag to support lazy evaluation of StatStruct field conversions?

@simeonschaub
Copy link
Contributor Author

I'm not quite sure what you mean by

Add additional error handling to libc and maybe a feature flag to support lazy evaluation of StatStruct field conversions?

But the first suggestion definitely seems reasonable, will make another PR shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants