fix: fix unexpected global name usage apache#13983.

add no-restricted-globals rule
rogeliotg · Jan 8, 2021 · 6d4fe65 · 6d4fe65
1 parent 68b7fab
commit 6d4fe65
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/.eslintrc-common.yaml b/.eslintrc-common.yaml
@@ -216,4 +216,14 @@ rules:
         -
             vars: "local"
             args: "none"
-    "@typescript-eslint/no-redeclare": 2
+    # Avoid dangerous usage of globals.
+    "no-restricted-globals":
+        - 2
+        - "event"
+        - "name"
+        - "length"
+        - "orientation"
+        - "top"
+        - "parent"
+        - "location"
+        - "closed"
diff --git a/src/data/Source.ts b/src/data/Source.ts
@@ -471,7 +471,7 @@ function normalizeDimensionsOption(dimensionsDefine: DimensionDefinitionLoose[])
         // User can set null in dimensions.
         // We dont auto specify name, othewise a given name may
         // cause it be refered unexpectedly.
-        if (name == null) {
+        if (item.name == null) {
             return item;
         }