updated fork #1
Open
updated fork #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CI asv check * added CI asv check * CI asv check * CI asv check * updated CI asv check * Update docs/sphinx/source/whatsnew/v0.9.2.rst updated v0.9.2.rst Co-authored-by: Kevin Anderson <[email protected]> Co-authored-by: Kevin Anderson <[email protected]>
This addresses 1 of the problems from #1275; The easiest tbh
* Added Benchmarking functions for * Solved more Stickler CI issues * Updated v0.9.2.rst * Made changes in code formatting Co-authored-by: Kevin Anderson <[email protected]>
* Added Benchmarking functions for * Solved more Stickler CI issues * Updated v0.9.2.rst * Made changes in code formatting Co-authored-by: Kevin Anderson <[email protected]>
* add pytest workflow * add some comments * set fail-fast to false * see if secrets work * move --remote-data tests to other workflow * remove secrets from default pytest workflow * simplify bare environment installation * simplify * un-simplify * thrashing around the "debug the CI" morass * fix macos py3.6 * disable codecov upload in azure pipelines * enable codecov in github actions * fix janky coverage hack * undo unnecessary changes to .coveragerc * add label reminder to PR template * rework workflows and codecov * whatsnew * remove azure config files * don't pytest on all pushes, only master * build sdist on PRs * switch to more convenient environment filenames * use most recent checkout action
* permit albedo to be a Series * work on modelchain * fix tests * shh stickler, docstrings * improve coverage * improve coverage correctly * finalize coverage, stickler * whatsnew * from review * don't mutate inputs * get_irradiance in tracking.py * shh stickler * shh stickler * improvements from review
* replace azure links w/ gh actions links in README * nix landscape; portrait is better anyway * nix coveralls; move codecov to build status
…function (#1480) * pvlib.tools.acosd * add calc_surface_orientation * prune singleaxis(), call calc_surface_orientation * tests * whatsnew * add calc_surface_orientation to sphinx api list * pr number * a bit of docstring cleanup * reference doi * include 0.9.2 on whatsnew page * Apply suggestions from code review Co-authored-by: Cliff Hansen <[email protected]> * mention right-handed rotation requirement * fix sphinx rendering issue * Apply suggestions from code review Co-authored-by: Cliff Hansen <[email protected]> Co-authored-by: Cliff Hansen <[email protected]>
* Create plot_pvfactors_fixed_tilt.py * whatsnew * add note in docstring parameter description * typo * Update pvlib/bifacial/pvfactors.py Co-authored-by: Cliff Hansen <[email protected]> * stickler Co-authored-by: Cliff Hansen <[email protected]>
* add reference * corrections Co-authored-by: Kevin Anderson <[email protected]>
* Add cams.get_cams_radiation function * Revert "Add cams.get_cams_radiation function" This reverts commit d7deb80. * Allow parsing of http files * Add test for https file * Squashed commit of the following: commit 5047b26 Author: Prajwal Borkar <[email protected]> Date: Tue May 17 19:14:53 2022 +0530 Updated get_cams protocol to https #1457 (#1458) * Updated get_cams protocol to https #1457 * Updated instances of http to https. #1457 * Updated documentation links to https * Added Contributor commit a0812b1 Author: roger-lcc <[email protected]> Date: Wed May 4 20:01:42 2022 +0800 CI asv check (#1454) * CI asv check * added CI asv check * CI asv check * CI asv check * updated CI asv check * Update docs/sphinx/source/whatsnew/v0.9.2.rst updated v0.9.2.rst Co-authored-by: Kevin Anderson <[email protected]> Co-authored-by: Kevin Anderson <[email protected]> commit 83e379a Author: Kevin Anderson <[email protected]> Date: Thu Apr 28 19:26:09 2022 -0400 Bump pandas to 0.25.0; test updates (#1448) * bump pandas min from 0.22.0 to 0.25.0 * fix buggy test__check_pandas_assert_kwargs don't use monkeypatch and mocker in the same test function. pytest-dev/pytest-mock#289 * fix psm3 test (apparent_zenith -> solar_zenith) * whatsnew * better UTC conversion in sun_rise_set_transit_ephem * helpful comments * more whatsnew * '3.0' -> '3' in read_crn test? * apply dtypes during parsing in read_crn * move dropna() post-processing into read_fwf call * fix read_crn for pandas<1.2.0 * Update pvlib/solarposition.py Co-authored-by: Will Holmgren <[email protected]> * nix pytz * UTC -> utc * address simd arccos issue in tracking.singleaxis Co-authored-by: Will Holmgren <[email protected]> commit 8d0f863 Author: Naman Priyadarshi <[email protected]> Date: Tue Apr 12 22:55:58 2022 +0530 Advance numba from 0.36.1 to 0.40.0 in asv py3.6 environment (#1440) * Advance numba from 0.36.1 to 0.40.0 * Advance numba from 0.36.1 to 0.40.0 * Updated whatsnew.rst commit 5cb695d Author: Naman Priyadarshi <[email protected]> Date: Wed Apr 6 23:58:03 2022 +0530 Remove unnecessary **kwargs from spa_python and get_total_irradiance (#1437) * Update Solarposition.py Removed **kwargs from pvlib.solarposition.spa_python * Added v0.9.2.rst, changes in pvlib/irradiance.py and pvlib/location.py Made new v0.9.2.rst and removed **kwargs from pvlib/irradiance.py (Line 309) and pvlib/location.py (Line 234-235) * Update docs/sphinx/source/whatsnew/v0.9.2.rst * Update docs/sphinx/source/whatsnew/v0.9.2.rst Co-authored-by: Kevin Anderson <[email protected]> commit 8460b36 Author: Kevin Anderson <[email protected]> Date: Tue Mar 29 15:31:25 2022 -0600 Finalize 0.9.1 (#1431) * fix heading levels in user_guide/bifacial.rst * whatsnew cleanup * fix readme html missing tag, maybe unicode zero-width spaces? * readme: link to universal zenodo doi * readme: update installation link for #1173 * whatsnew date * additional contributors * delete errant space commit edbf2a6 Author: RoyCoding8 <[email protected]> Date: Wed Mar 30 01:58:18 2022 +0530 Updated plot_singlediode.py (#1434) * Update plot_singlediode.py Changed the unit from C to degree C (°C) * Update plot_singlediode.py Changed to LaTeX \degree symbol in matplotlib which avoids any encoding issues with using Unicode characters. * Update v0.9.1.rst Added name to the contributors' list * Update v0.9.1.rst commit cf4a8ad Author: Kevin Anderson <[email protected]> Date: Tue Mar 29 14:04:40 2022 -0600 Update sphinx to 4.5.0 (#1435) * bump sphinx and pydata-sphinx-theme versions * clean up sphinx conf.py * fix distutils strangeness, maybe * use freshly-released sphinx==4.5.0 commit 884a153 Author: Kevin Anderson <[email protected]> Date: Wed Mar 23 13:41:35 2022 -0600 Clarify delta_t docstring descriptions (#1429) * clarify delta_t docstrings * whatsnew commit c243183 Author: Kevin Anderson <[email protected]> Date: Thu Mar 17 12:01:57 2022 -0600 Deprecate pvlib.forecast (#1426) * deprecate pvlib.forecast classes * catch warnings in tests * add warning admonition to forecasts.rst * whatsnew * stickler * pin pytest < 7.1.0 * pin pytest in the right place this time * more warning suppression in tests * unpin pytest * Update docs/sphinx/source/whatsnew/v0.9.1.rst * copy warning to reference/forecasting.rst commit e3baa12 Author: Kevin Anderson <[email protected]> Date: Thu Mar 17 11:28:56 2022 -0600 Fix conditional dependency on dataclasses (#1422) * better conditional dependency on dataclasses * whatsnew commit 27cba7a Author: Naman Priyadarshi <[email protected]> Date: Thu Mar 17 22:48:08 2022 +0530 Added asv benchmarking badge to the table of badges in the main README. (#1427) * Update Readme.md Added benchmarks asv badge to the badge section * Updated v.0.9.1.rst Added my name to the list of Contributers. commit 1893b20 Author: Adam R. Jensen <[email protected]> Date: Mon Mar 14 18:37:58 2022 +0100 Add variable mapping of psm3 (#1374) * Add variable mapping of psm3 * Add enhancement entry in whatsnew * Fix stickler * Map keys in metadata dict * Remove double spaces in docs * Fix stickler * Doc update Co-authored-by: Kevin Anderson <[email protected]> * Reformatting - changes by kanderso-nrel * Update docstring table with 2020 * Add deprecation warning test coverage * Rename to VARIABLE_MAP * Change apparent_zenith to solar_zenith Based on the decision in #1403 * Update attributes docstring * Change elevation to altitude when mapping variables * Update psm3 variable mapping test Co-authored-by: Kevin Anderson <[email protected]> * Revert "Squashed commit of the following:" This reverts commit b313c64. * Update whatsnew * Update read_surfrad documentation Co-authored-by: AdamRJensen <[email protected]>
- Replace conda setup with micromamba - Reduce fetch depth for checkout - Fetch tags for version inference - Install pvlib from source before testing Closes #1472 Co-authored-by: Kevin Anderson <[email protected]>
) * docstring updated to indicate limits of axis_tilt * updated additional docstrings where the axis_tilt variable is found * added kurt-rhee to v0.9.2.rst whats new file * changed calc_axis_tilt description of axis tilt * Update pvlib/tracking.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/tracking.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/tracking.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/tracking.py Co-authored-by: Cliff Hansen <[email protected]> Co-authored-by: Cliff Hansen <[email protected]> Co-authored-by: Kevin Anderson <[email protected]>
…clearsky (#1490) * edit error message for unequal times * similar edits to prilliman docstring * whatsnew
* drop py3.6 * bump CI from macos-10.15 to macos-latest * add testing on py3.10 * remove dataclasses requirement * whatsnew
* Add deprecation for leap_day * Add test coverage * Do not raise warning for TMY requests * Replace & by and, and update whatsnew * Update whatsnew Update whatsnew with suggestion from cwhanse Co-authored-by: Cliff Hansen <[email protected]> Co-authored-by: Cliff Hansen <[email protected]>
* Updated PVGIS docs * Update test_pvgis.py * Replace CMSAF testfile with SARAH2 * Set components=0 for json output in test_pvgis * Specify url in args_pv_json
* Update read_tmy3 date shift * Add test coverage * Add whatsnew entry * Clean up TMY3 table * Add comments to test files * Fix stickler * Update admonition * Apply changes from kanderso-nrel * Add encoding option to read_tmy3 * Fix stickler * Update pvlib/iotools/tmy.py Co-authored-by: Kevin Anderson <[email protected]> * Remove encoding parameter and add try/except * Fix incorrect parenthesis * Add fbuf.close and first within try/except * Add finally clause * Utilize open and add _parse_tmy3 * Fix stickler Co-authored-by: Kevin Anderson <[email protected]>
- Remove pvlib/_version.py (versioneer) - Use importlib.metadata to retrieve version from PKG-INFO - Add importlib-metadata backport for python < 3.8 - Create pyproject.toml with setuptools build backend - Update workflow to use pypa/build module to build sdist & wheel - Update remove versioneer files from .lgtm.yml & .stickler.yml - Remove include from MANIFEST.IN (already included with setuptools-scm)
* setup.py: use setuptools.find_packages() * switch to better method; add documentation * more comment * use stable pypi release action should hopefully address and silence this warning: Warning: You are using "pypa/gh-action-pypi-publish@master". The "master" branch of this project has been sunset and will not receive any updates, not even security bug fixes. Please, make sure to use a supported version. If you want to pin to v1 major version, use "pypa/gh-action-pypi-publish@release/v1". If you feel adventurous, you may opt to use use "pypa/gh-action-pypi-publish@unstable/v1" instead. A more general recommendation is to pin to exact tags or commit shas. * some pruning * fix errors
* Update cams links * Update whatsnew * Rename CAMS_VARIABLE_MAP to VARIABLE_MAP
* permit albedo to be a Series * work on modelchain * fix tests * shh stickler, docstrings * improve coverage * improve coverage correctly * finalize coverage, stickler * whatsnew * from review * don't mutate inputs * get_irradiance in tracking.py * shh stickler * shh stickler * improvements from review * update whatsnew * Apply suggestions from code review Co-authored-by: Kevin Anderson <[email protected]> * docstring improvements * Apply suggestions from code review Co-authored-by: Will Holmgren <[email protected]> * Update pvlib/tests/test_irradiance.py Co-authored-by: Will Holmgren <[email protected]> * from review * one more * more use of fixture, add Array.get_irradiance test * more decimal places * spacing * line length * write albedo from system.arrays to ModelChainResult Co-authored-by: Kevin Anderson <[email protected]> Co-authored-by: Will Holmgren <[email protected]>
* 0.9.2 whatsnew cleanup * create empty 0.9.3 whatsnew template * missed contributors
…1540) * removing closed parameter from pandas daframes * Update v0.9.3.rst * Apply suggestions from code review * Update docs/examples/solar-tracking/plot_single_axis_tracking_on_sloped_terrain.py * Apply suggestions from code review Co-authored-by: Cliff Hansen <[email protected]> Co-authored-by: Kevin Anderson <[email protected]>
* Lookup altitude implementation * Adding test for lookup altitude * Updating reference for lookup altitude * Adding whatsnew documentation * Adding myself as a contribuitor * slight documentation improvemnts * Switching back to original _degrees_to_index. There is a bug in the new implementation when numbers hit the boundaries * Fix style issue Removing extra empty line at the end of the file * Updating altitude lookup map Using new map so is reproducible with script https://gist.github.com/nicomt/d2c5f08a8ee3500550be42d8dbee6c1d * Update pvlib/location.py Small documentation change Co-authored-by: Cliff Hansen <[email protected]> * Moving _degrees_to_index test to test_tools * Update lookup_location * Retuning float altitude instead of int * Removing h5 file input * Moving whatsnew to next release Co-authored-by: Cliff Hansen <[email protected]>
* first experimental commit * Added numpy array support * changed var names * changed townsend_Se to private * removed snow.loss_townsend in api.rst * added loss_townsend description in effects_on_pv_system_output.rst * fixed stickler checks * removed rounding of loss and changed to 0-1 range Several other small changes - variable names change, comment change - in response to Kevin's review notes * implementing changes suggested in PR #1251 * removing new line * removing new line * remove new line * Se to effective_snow * adding PR number to whatsnew * address stickler line too long * remove links and noqa E501, and fix long lines * converting to metric system * poa_global from kWh/m2 to Wh/m2 * changing returned loss from kWh to Wh * fixing capacity loss calculation units to keep correct C1 value * convert relative humidity from percent to fraction * neatening docstrings and adjusting variable names * changing eqn 3 percentage loss to fractional loss and adding comment explanation Co-authored-by: Abhishek Parikh <[email protected]> Co-authored-by: abhisheksparikh <[email protected]>
* Add mismatch module in pvlib.spectrum * Add utility function to produce a sample sr to work or play with. * Add reference spectrum file and reader function. * Add the mismatch calculation. * Add tests and expand doc strings. * Update whatnew and placate Stickler. * Change am15 file from xls to csv; doc string expansion and misc small changes. * Adjust __init__.py and imports; sphynx references; whatsnew. * Undo whatsnew v0.9.2 * Resolve multiple issues from ongoing review. * Make many improvements based on reviews. * Fix indentation and __init__.py * Polish docstrings some more. * Add explanation of truncation strategy. * Final touches. * Expand explanation for truncation Co-authored-by: Cliff Hansen <[email protected]>
* First commit to gather feedback on class design. * Changed set_*/get_* pattern to use_*/to_* * Add generic_linear() as a separate module temperature function and adjustments to doc strings. * Add tests. * Minor test edits. * One more test to achieve 100% coverage (hopefully). * Some formatting, docstring development. * Try to update sphynx. * Try sphynx again. * Docstrings nearing completion. * Docstrings complete. * One more small name change. * Fix problems identified in reviews. * Update whatsnew. Co-authored-by: Kevin Anderson <[email protected]>
* Description for tracking.calc_cross_axis_tilt The previous description for the signs of cross axis tilt mentioned slope azimuth as east for both positive and negative. Corrected it to indicate that sign of cross axis tilt is positive when axis azimuth is south and slope is towards west. * up to down * Update docs/sphinx/source/whatsnew/v0.9.3.rst Co-authored-by: Kevin Anderson <[email protected]> * Update docs/sphinx/source/whatsnew/v0.9.3.rst Co-authored-by: Kevin Anderson <[email protected]> Co-authored-by: Cliff Hansen <[email protected]> Co-authored-by: Kevin Anderson <[email protected]>
* whatsnew cleanup * include 0.9.3 in whatsnew index * create empty 0.9.4 whatsnew template * sphinx fixes * release date += 1
* fixing issues * fix long lines * whats new file edited * Comments from review Co-authored-by: Christian Orner <[email protected]>
…1568) * haydavies_return_components Update the Hay Davies sky transposition model to return individual components by user request. * updating_return_components Added in horizon component, which defaults to 0 or NaN. Also updating some stickler issues. * stickler_stickler Updating formatting in file to be in line with stickler. Updating contributors list and corresponding information. * testing_update adding in test for when pandas is not being used. * docstring update * cleaning_updates * testing_updates updated tests for various data types. Co-authored-by: Kevin Anderson <[email protected]>
…#1567) * added new irradiance function for component sum * added to docstrings * updated docstrings * updated methods with new component_sum_irradiance() function * added associated unit test for the new component sum function * added units tests for the component_sum_irradiance() function * added whatsnew file for v0.9.4 * fixed modelchain error to stop unit test erroring * removed clearsky_dni arg for cases where it's not used * updated naming conventions for component_sum_irradiance function in modelchains * updated the routines to remove pep8 errors, added to clearsky_dni docstring * updated the routine to return dataframe after calculating component sum + other suggestions * updated the PR based on @kanderso-nrel review * made updates based on kanderso-nrel's suggestions * updated all the unit tests to pass * Update pvlib/irradiance.py Co-authored-by: Kevin Anderson <[email protected]> * Update pvlib/irradiance.py Co-authored-by: Kevin Anderson <[email protected]> * moved warning out of dni generation call (just ghi and dhi) * fix sticklerci formatting errors * Update pvlib/irradiance.py Co-authored-by: Kevin Anderson <[email protected]> * updates to name-changed to 'complete_irradiance' * fixed over-indentation error * removed default none from function params * Update docs/sphinx/source/whatsnew/v0.9.4.rst Co-authored-by: Cliff Hansen <[email protected]> * made updates based on @cwhanse's recommendations * Update pvlib/irradiance.py Co-authored-by: Will Holmgren <[email protected]> * Update pvlib/irradiance.py Co-authored-by: Will Holmgren <[email protected]> * changed to pytest error raise based on @wholmgren's recommendation * Made updates to code based on @wholmgren's recommendations * fix pep8 error 2 * updated modelchains to use zenith instead of apparent zenith * check that unit tests run * undo ModelChain.complete_irradiance test changes Co-authored-by: Perry <[email protected]> Co-authored-by: Kevin Anderson <[email protected]> Co-authored-by: Cliff Hansen <[email protected]> Co-authored-by: Will Holmgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.