Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes monitor representation #68

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

cmilanf
Copy link
Contributor

@cmilanf cmilanf commented Sep 22, 2024

Monitor.__repr__() was missing a key in the formating that prevented the example of the README.md from this repostory from working.

At Monitor.__init__():
self._fmt = "{}(id={}, name={}, controllable={})"

self._fmt is expecting four keys, but Monitor.__repr__() is only providing three:

def __repr__(self) -> str:
        """Representation of a Monitor."""
        return self._fmt.format(self.__class__.__name__, self.id, self.name)

I just added the missing one:

def __repr__(self) -> str:
        """Representation of a Monitor."""
        return self._fmt.format(self.__class__.__name__, self.id, self.name, self.controllable)

Copy link
Collaborator

@nabbi nabbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #61 thanks

@nabbi nabbi merged commit 1b5475e into rohankapoorcom:develop Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants