Skip to content

Fix: Add fork instructions to git lesson to resolve authentication er…#296

Open
Noorislam-XD wants to merge 2 commits into
rohitg00:mainfrom
Noorislam-XD:main
Open

Fix: Add fork instructions to git lesson to resolve authentication er…#296
Noorislam-XD wants to merge 2 commits into
rohitg00:mainfrom
Noorislam-XD:main

Conversation

@Noorislam-XD

@Noorislam-XD Noorislam-XD commented Jun 16, 2026

Copy link
Copy Markdown

…rors

  • Updated Step 4 to require forking the repository first
  • Clarified that students must clone from their own fork to be able to push
  • Added optional instructions for syncing with upstream changes
  • Updated Exercise 1 to include the fork step
  • Fixes [bug] Directions in 00/02 Git and Collaboration #292: "Remote: Invalid username or token" error when trying to push to main repo

What this PR does

Kind of change

  • New lesson
  • Fix to an existing lesson
  • Translation
  • New output (prompt, skill, agent, MCP server)
  • Docs / website / tooling

Checklist

  • Code runs without errors with the listed dependencies
  • No comments in code files (docs explain, code is self-explanatory)
  • Built from scratch first, then shown with a framework (for new lessons)
  • Lesson folder matches LESSON_TEMPLATE.md structure
  • ROADMAP.md row for the lesson is a markdown link ([Name](phases/...)), not bare text
  • One lesson per commit (atomic per-lesson rule)
  • Tested locally / code output matches what docs/en.md claims

Phase / lesson

Notes for reviewer

…rors

- Updated Step 4 to require forking the repository first
- Clarified that students must clone from their own fork to be able to push
- Added optional instructions for syncing with upstream changes
- Updated Exercise 1 to include the fork step
- Fixes rohitg00#292: "Remote: Invalid username or token" error when trying to push to main repo
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f19f79c2-aeb6-455d-b3ed-9a4fc16b06a2

📥 Commits

Reviewing files that changed from the base of the PR and between b56c9f2 and 5759adc.

📒 Files selected for processing (1)
  • phases/00-setup-and-tooling/02-git-and-collaboration/docs/en.md
✅ Files skipped from review due to trivial changes (1)
  • phases/00-setup-and-tooling/02-git-and-collaboration/docs/en.md

📝 Walkthrough

Walkthrough

The Git & Collaboration lesson doc is updated to replace the direct-clone workflow with a fork-first approach. The "Working with this course repo" section now instructs students to fork the repo, clone their fork, create a my-progress branch, push it, and optionally sync with upstream. The first exercise step is updated to match.

Changes

Fork-first workflow in Git & Collaboration lesson

Layer / File(s) Summary
Fork-first workflow and exercise update
phases/00-setup-and-tooling/02-git-and-collaboration/docs/en.md
"Working with this course repo" section replaces direct-clone instructions with fork, clone-fork, my-progress branch creation, push, and optional upstream sync steps via git remote add upstream, git fetch, and git merge upstream/main; first exercise step is updated to explicitly require forking before cloning, branching, committing, and pushing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title correctly identifies the main change: adding fork instructions to resolve authentication errors in the git lesson.
Description check ✅ Passed The description is related to the changeset, explaining the updates to git collaboration instructions and linking to the authentication error issue.
Linked Issues check ✅ Passed The PR successfully addresses issue #292 by adding fork instructions, clarifying the clone-from-fork requirement, and updating exercises to prevent authentication errors.
Out of Scope Changes check ✅ Passed All changes are scoped to the git lesson documentation, focusing on fork and clone instructions directly addressing the authentication error issue #292.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
phases/00-setup-and-tooling/02-git-and-collaboration/docs/en.md (1)

76-76: 💤 Low value

Hardcoded repository URL may require maintenance if the repo location changes.

Lines 76 and 92 both reference the hardcoded GitHub URL https://github.com/rohitg00/ai-engineering-from-scratch. If the repository is ever moved or renamed, this lesson will provide outdated instructions. Consider whether a placeholder or variable reference would be more maintainable.

Also applies to: 92-92

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@phases/00-setup-and-tooling/02-git-and-collaboration/docs/en.md` at line 76,
The documentation contains hardcoded references to the GitHub repository URL
https://github.com/rohitg00/ai-engineering-from-scratch in multiple locations
within the file. These hardcoded URLs require manual updates if the repository
is ever moved or renamed. Replace these hardcoded URL instances with a
placeholder variable or reference (such as a template variable like {{REPO_URL}}
or a note indicating where the actual repository URL should be substituted) to
make the documentation more maintainable and less prone to becoming outdated if
the repository location changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@phases/00-setup-and-tooling/02-git-and-collaboration/docs/en.md`:
- Line 76: The documentation contains hardcoded references to the GitHub
repository URL https://github.com/rohitg00/ai-engineering-from-scratch in
multiple locations within the file. These hardcoded URLs require manual updates
if the repository is ever moved or renamed. Replace these hardcoded URL
instances with a placeholder variable or reference (such as a template variable
like {{REPO_URL}} or a note indicating where the actual repository URL should be
substituted) to make the documentation more maintainable and less prone to
becoming outdated if the repository location changes.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9b2eaf60-b7d6-41ca-a340-67e119460439

📥 Commits

Reviewing files that changed from the base of the PR and between 574a5d6 and b56c9f2.

📒 Files selected for processing (1)
  • phases/00-setup-and-tooling/02-git-and-collaboration/docs/en.md

@Noorislam-XD Noorislam-XD reopened this Jun 16, 2026
Jayantkhandebharad pushed a commit to Jayantkhandebharad/ai-engineering-from-scratch that referenced this pull request Jun 19, 2026
…pstream rohitg00#296]

Adopted from upstream rohitg00/ai-engineering-from-scratch
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Convert hardcoded URL on line 76 to a markdown link for better maintainability
- Keeps the upstream sync URL as-is (appears in command example, not narrative text)
- Makes it easier to update documentation if repository location changes
- Addresses CodeRabbit review feedback on maintainability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Directions in 00/02 Git and Collaboration

1 participant