Fix: Add fork instructions to git lesson to resolve authentication er…#296
Fix: Add fork instructions to git lesson to resolve authentication er…#296Noorislam-XD wants to merge 2 commits into
Conversation
…rors - Updated Step 4 to require forking the repository first - Clarified that students must clone from their own fork to be able to push - Added optional instructions for syncing with upstream changes - Updated Exercise 1 to include the fork step - Fixes rohitg00#292: "Remote: Invalid username or token" error when trying to push to main repo
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe Git & Collaboration lesson doc is updated to replace the direct-clone workflow with a fork-first approach. The "Working with this course repo" section now instructs students to fork the repo, clone their fork, create a ChangesFork-first workflow in Git & Collaboration lesson
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
phases/00-setup-and-tooling/02-git-and-collaboration/docs/en.md (1)
76-76: 💤 Low valueHardcoded repository URL may require maintenance if the repo location changes.
Lines 76 and 92 both reference the hardcoded GitHub URL
https://github.com/rohitg00/ai-engineering-from-scratch. If the repository is ever moved or renamed, this lesson will provide outdated instructions. Consider whether a placeholder or variable reference would be more maintainable.Also applies to: 92-92
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@phases/00-setup-and-tooling/02-git-and-collaboration/docs/en.md` at line 76, The documentation contains hardcoded references to the GitHub repository URL https://github.com/rohitg00/ai-engineering-from-scratch in multiple locations within the file. These hardcoded URLs require manual updates if the repository is ever moved or renamed. Replace these hardcoded URL instances with a placeholder variable or reference (such as a template variable like {{REPO_URL}} or a note indicating where the actual repository URL should be substituted) to make the documentation more maintainable and less prone to becoming outdated if the repository location changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@phases/00-setup-and-tooling/02-git-and-collaboration/docs/en.md`:
- Line 76: The documentation contains hardcoded references to the GitHub
repository URL https://github.com/rohitg00/ai-engineering-from-scratch in
multiple locations within the file. These hardcoded URLs require manual updates
if the repository is ever moved or renamed. Replace these hardcoded URL
instances with a placeholder variable or reference (such as a template variable
like {{REPO_URL}} or a note indicating where the actual repository URL should be
substituted) to make the documentation more maintainable and less prone to
becoming outdated if the repository location changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9b2eaf60-b7d6-41ca-a340-67e119460439
📒 Files selected for processing (1)
phases/00-setup-and-tooling/02-git-and-collaboration/docs/en.md
…pstream rohitg00#296] Adopted from upstream rohitg00/ai-engineering-from-scratch Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Convert hardcoded URL on line 76 to a markdown link for better maintainability - Keeps the upstream sync URL as-is (appears in command example, not narrative text) - Makes it easier to update documentation if repository location changes - Addresses CodeRabbit review feedback on maintainability
…rors
What this PR does
Kind of change
Checklist
LESSON_TEMPLATE.mdstructure[Name](phases/...)), not bare textdocs/en.mdclaimsPhase / lesson
Notes for reviewer