Skip to content

fix: correct terminal shortcuts in 08-editor-setup (fixes #305)#306

Open
Kunalthakur01 wants to merge 2 commits into
rohitg00:mainfrom
Kunalthakur01:fix/editor-shortcuts-issue-305
Open

fix: correct terminal shortcuts in 08-editor-setup (fixes #305)#306
Kunalthakur01 wants to merge 2 commits into
rohitg00:mainfrom
Kunalthakur01:fix/editor-shortcuts-issue-305

Conversation

@Kunalthakur01

Copy link
Copy Markdown

What this PR does

Kind of change

Check only this box:

Fix to an existing lesson

Checklist

Check only these (others don't apply to a doc fix):

Tested locally / code output matches what docs/en.md claims

Phase / lesson

Notes for reviewer

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d9e705e1-9a9f-4d26-a9ba-0061f762a900

📥 Commits

Reviewing files that changed from the base of the PR and between cd16315 and 8adafb5.

📒 Files selected for processing (1)
  • phases/00-setup-and-tooling/08-editor-setup/docs/en.md

📝 Walkthrough

Walkthrough

Two lines in phases/00-setup-and-tooling/08-editor-setup/docs/en.md are corrected: Step 2 now specifies Ctrl+`` as the integrated terminal shortcut on all platforms and adds the View → Terminal menu path; Step 4 updates the Linux/Windows split terminal shortcut from Ctrl+` to Ctrl+Shift+5.

Changes

Editor Setup Documentation — Terminal Shortcut Corrections

Layer / File(s) Summary
Terminal shortcut text corrections
phases/00-setup-and-tooling/08-editor-setup/docs/en.md
Step 2 integrated terminal shortcut is updated to specify Ctrl+`` on all platforms with an added View → Terminal menu alternative. Step 4 Linux/Windows split terminal shortcut is corrected from Ctrl+` to Ctrl+Shift+5.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

  • [bug] Incorrect Shortcuts in 00/08 Editor Set Up #305: This PR directly addresses the reported incorrect terminal shortcut descriptions — specifying Ctrl+`` for toggling the terminal on all platforms and correcting the split terminal shortcut to Ctrl+Shift+5` on Linux/Windows — in the same editor setup documentation file.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: correcting terminal shortcuts in the 08-editor-setup documentation file, and references the associated issue.
Description check ✅ Passed The description is directly related to the changeset, providing clear details about the two shortcut errors being fixed and explaining the corrections made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@phases/00-setup-and-tooling/08-editor-setup/docs/en.md`:
- Line 127: The macOS shortcut for the Split terminal command in the keyboard
shortcuts table is incorrect. Locate the table row with "Split terminal" and
replace the macOS shortcut value from Cmd+Shift+5 to Cmd+\ (or ⌘\) to match VS
Code's official documentation, while keeping the Windows/Linux shortcut
Ctrl+Shift+5 unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 04cf0361-9faf-40d5-a2d1-4efe952dfc48

📥 Commits

Reviewing files that changed from the base of the PR and between 574a5d6 and cd16315.

📒 Files selected for processing (1)
  • phases/00-setup-and-tooling/08-editor-setup/docs/en.md

Comment thread phases/00-setup-and-tooling/08-editor-setup/docs/en.md Outdated

@Kunalthakur01 Kunalthakur01 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kunalthakur01 Kunalthakur01 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant