docs(phase-00): add macOS/MPS branch to env-check prompt#317
Open
bhuiyanmobasshir94 wants to merge 1 commit into
Open
docs(phase-00): add macOS/MPS branch to env-check prompt#317bhuiyanmobasshir94 wants to merge 1 commit into
bhuiyanmobasshir94 wants to merge 1 commit into
Conversation
The CUDA-not-detected guidance pointed all users at `nvidia-smi` and a CUDA-versioned PyTorch reinstall. On macOS / Apple Silicon there is no CUDA and no `nvidia-smi`, so that advice loops. Split the bullet: Linux/Windows+NVIDIA keep the CUDA path; macOS gets an MPS branch that says no CUDA is expected, skip `--index-url .../cuXXX`, install plain torch, and verify `torch.backends.mps.is_available()` is True. Refs rohitg00#316 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesCUDA/MPS Platform Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
prompt-env-checkdiagnostician prompt (Phase 0, Lesson 1) told all users to handle "CUDA not detected" by runningnvidia-smiand reinstalling PyTorch with a CUDA version. On macOS / Apple Silicon there is no CUDA and nonvidia-smi, so that advice loops with no resolution.Change
Split the CUDA bullet into two:
nvidia-smi+ CUDA-versioned reinstall path.--index-url .../cuXXX, install plainuv pip install torch torchvision torchaudio, and verify the MPS (Metal) backend withtorch.backends.mps.is_available().Why
Following the original CUDA command on a Mac fails —
download.pytorch.org/whl/cu124has nomacosx_arm64wheels. Verified locally that the plain install yields a working MPS build:verify.pypasses 7/7 core checks after setup.Refs #316
🤖 Generated with Claude Code