Skip to content

Allow disabling payload logging on non-200 status #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow disabling payload logging on non-200 status #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions rollbar/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ def _get_fastapi_request():
'capture_username': False,
'capture_ip': True,
'log_all_rate_limited_items': True,
'log_payload_on_error': True,
'http_proxy': None,
'http_proxy_user': None,
'http_proxy_password': None,
Expand Down Expand Up @@ -1730,7 +1731,9 @@ def _parse_response(path, access_token, params, resp, endpoint=None):

if resp.status_code == 429:
if SETTINGS['log_all_rate_limited_items'] or not last_response_was_429:
log.warning("Rollbar: over rate limit, data was dropped. Payload was: %r", params)
log.warning("Rollbar: over rate limit, data was dropped.")
if SETTINGS['log_payload_on_error']:
log.warning("Payload was: %r", params)
return
elif resp.status_code == 502:
log.exception('Rollbar api returned a 502')
Expand All @@ -1743,7 +1746,9 @@ def _parse_response(path, access_token, params, resp, endpoint=None):
payload = json.loads(params)
uuid = payload['data']['uuid']
host = payload['data']['server']['host']
log.error("Rollbar: request entity too large for UUID %r\n. Payload:\n%r", uuid, payload)
log.error("Rollbar: request entity too large for UUID %r\n.", uuid)
if SETTINGS['log_payload_on_error']:
log.error("Payload:\n%r", payload)
except (TypeError, ValueError):
log.exception('Unable to decode JSON for failsafe.')
except KeyError:
Expand Down