Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: use uncaughtErrorLevel #896

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

freewil
Copy link

@freewil freewil commented Oct 12, 2020

Description of the change

Server: Fix unhandled errors so that they are logged at uncaughtErrorLevel.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@waltjones waltjones self-requested a review October 12, 2020 18:40
@jmarronm
Copy link

@waltjones is this PR still valid?
Can we consider Merging or Closing it, please?

@jmarronm
Copy link

Old PR from 2020
@waltjones can you take a look and consider closing/merging?
Otherwise, I will close it in my next check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants