-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not review] feat: TlsSocket AsyncWriteSome and AsyncReadSome #376
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: kostas <[email protected]>
Do not review, it's not ready |
@@ -388,6 +388,7 @@ void EpollSocket::AsyncWriteSome(const iovec* v, uint32_t len, io::AsyncProgress | |||
async_write_pending_ = 1; | |||
} | |||
|
|||
// TODO implement async functionality | |||
void EpollSocket::AsyncReadSome(const iovec* v, uint32_t len, io::AsyncProgressCb cb) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
epoll AsyncRead
is synchronous
Signed-off-by: kostas <[email protected]>
@@ -0,0 +1,34 @@ | |||
-----BEGIN CERTIFICATE----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 50 years
will be enough for this to last 🤓 (that's the --days I used to generate it)
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 77.60% 77.67% +0.06%
==========================================
Files 103 112 +9
Lines 7824 9557 +1733
==========================================
+ Hits 6072 7423 +1351
- Misses 1752 2134 +382 ☔ View full report in Codecov by Sentry. |
Implement async io for
TlsSocket
.Resolves #361 when ready.
There are a few things that need to be fixed/implemented: