Skip to content

WIP: ExMonobank.MerchantAPI - #20

Open
sveredyuk wants to merge 11 commits into
romkor:masterfrom
sveredyuk:merchant_api
Open

WIP: ExMonobank.MerchantAPI#20
sveredyuk wants to merge 11 commits into
romkor:masterfrom
sveredyuk:merchant_api

Conversation

@sveredyuk

Copy link
Copy Markdown

@romkor I Just started extracting my code into ExMonobank.MerchantAPI. Work in progress, but we can start the discussion right now )

@romkor romkor left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
I have mixed fillings about Invoice module name, not clear that it is mutation DTO.
But I can live with it.
WDYT?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, just typo in file name:
cancel_invoice_failure_with_inbvalid_id.json
should be:
cancel_invoice_failure_with_invalid_id.json

@sveredyuk

Copy link
Copy Markdown
Author

Good job! I have mixed feelings about Invoice module name, not clear that it is mutation DTO. But I can live with it. WDYT?

Me too. We need clear separate request structs and response structs. I'm just bad at naming :)
ExMonobank.Invoice - request struct
ExMonobank.InvoiceInfo - response structs

{:ok, invoice_info} =
  %{amount: 100}
  |> ExMonobank.Invoice.new()
  |> MerchantAPI.create_invoice()

I am open to any suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants