Skip to content

osprey-stress: refresh measure/open-loop wording now that #236 merged - #438

Merged
julietshen merged 2 commits into
mainfrom
julietshen/stress-236-language
Jul 22, 2026
Merged

osprey-stress: refresh measure/open-loop wording now that #236 merged#438
julietshen merged 2 commits into
mainfrom
julietshen/stress-236-language

Conversation

@julietshen

@julietshen julietshen commented Jul 20, 2026

Copy link
Copy Markdown
Member

The JetStream input stream sample (#236) has merged, so the "once #236 lands" wording in the osprey-stress measure stub and the consumer/reporter docstrings is now stale.

This is a wording-only change (no behavior change):

Follow-up: actually implementing the open-loop measure mode is tracked separately.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified that the measure command is an open-loop measurement mode that is not yet implemented.
    • Updated CLI guidance to use run instead.
    • Expanded documentation to describe support for externally produced event sources, including JetStream input streams.
    • Clarified that per-event latency cannot be calculated in open-loop mode.

The JetStream input stream sample (#236) has merged, so the "once #236
lands" framing in the `measure` stub and the consumer/reporter docstrings
is stale. Reword to say the prerequisite external source now exists (the
JetStream stream is one), while making clear that `run` is the working
closed-loop stress test and `measure` (open-loop) is simply not implemented
yet. No behavior change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TEcfpqhza3dPepZUVWw36X
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: eb3c514a-68f1-48b4-aa9d-3d1c1fe907cb

📥 Commits

Reviewing files that changed from the base of the PR and between a5768a5 and 0633fa6.

📒 Files selected for processing (3)
  • osprey_worker/src/osprey/worker/stress/cli.py
  • osprey_worker/src/osprey/worker/stress/consumer.py
  • osprey_worker/src/osprey/worker/stress/reporter.py

📝 Walkthrough

Walkthrough

The stress harness now describes measure as an unimplemented open-loop mode, directs users to run, and generalizes external-source documentation to include the JetStream input stream.

Changes

Stress harness open-loop messaging

Layer / File(s) Summary
Measure mode guidance
osprey_worker/src/osprey/worker/stress/cli.py, osprey_worker/src/osprey/worker/stress/consumer.py, osprey_worker/src/osprey/worker/stress/reporter.py
CLI help and stub output identify measure as unimplemented open-loop functionality and direct users to run; stress harness docstrings describe external input sources, including JetStream.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: exbreder

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the wording refresh for measure/open-loop docs after #236 merged.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch julietshen/stress-236-language

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@julietshen
julietshen merged commit 68447c3 into main Jul 22, 2026
13 checks passed
@julietshen
julietshen deleted the julietshen/stress-236-language branch July 22, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants