Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clad] Bump clad to version v1.9 #16982

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

vgvassilev
Copy link
Member

No description provided.

@vgvassilev
Copy link
Member Author

@guitargeek, could you do some performance benchmarks to see if we have not regressed?

Copy link

github-actions bot commented Nov 19, 2024

Test Results

    18 files      18 suites   3d 19h 49m 39s ⏱️
 2 719 tests  2 719 ✅ 0 💤 0 ❌
47 253 runs  47 253 ✅ 0 💤 0 ❌

Results for commit aa18e0b.

♻️ This comment has been updated with latest results.

@guitargeek
Copy link
Contributor

I have checked, and there are no changes in jitting time and runtime for ATLAS and CMS Higgs combination fits.

@dpiparo
Copy link
Member

dpiparo commented Nov 22, 2024

@guitargeek can this PR then be approved?

@guitargeek
Copy link
Contributor

Well, not as it is. We can't use Clad master as a dependency. There first needs to be a new release and then this PR needs to be updated to use the tag of that release.

@vgvassilev
Copy link
Member Author

Also there is a regression on windows that I am bisecting.

@dpiparo
Copy link
Member

dpiparo commented Nov 22, 2024

Thanks, good that this is being followed up.

@hahnjo hahnjo marked this pull request as draft November 25, 2024 07:47
@guitargeek guitargeek removed their request for review February 21, 2025 10:46
@vgvassilev vgvassilev changed the title [clad] Bump to master, checking if we can release. [clad] Bump clad to version v1.9 Feb 25, 2025
@vgvassilev vgvassilev marked this pull request as ready for review February 25, 2025 15:08
@vgvassilev
Copy link
Member Author

@guitargeek ping.

@guitargeek
Copy link
Contributor

Hi @vgvassilev, thanks for the ping, I forgot to report on my findings here. Clad 1.9 works for both the ATLAS and CMS Higgs combination examples that we have and presented at ICHEP 2024.

@vgvassilev
Copy link
Member Author

Hi @vgvassilev, thanks for the ping, I forgot to report on my findings here. Clad 1.9 works for both the ATLAS and CMS Higgs combination examples that we have and presented at ICHEP 2024.

Great to hear. Let's move forward then.

Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating Clad in ROOT to v1.9!

@vgvassilev vgvassilev merged commit 842fa29 into root-project:master Mar 7, 2025
21 checks passed
@vgvassilev vgvassilev deleted the check-clad-master branch March 7, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants