-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clad] Bump clad to version v1.9 #16982
Conversation
@guitargeek, could you do some performance benchmarks to see if we have not regressed? |
Test Results 18 files 18 suites 3d 19h 49m 39s ⏱️ Results for commit aa18e0b. ♻️ This comment has been updated with latest results. |
I have checked, and there are no changes in jitting time and runtime for ATLAS and CMS Higgs combination fits. |
@guitargeek can this PR then be approved? |
Well, not as it is. We can't use Clad |
Also there is a regression on windows that I am bisecting. |
Thanks, good that this is being followed up. |
42651e3
to
bbf4b79
Compare
bbf4b79
to
aa18e0b
Compare
@guitargeek ping. |
Hi @vgvassilev, thanks for the ping, I forgot to report on my findings here. Clad 1.9 works for both the ATLAS and CMS Higgs combination examples that we have and presented at ICHEP 2024. |
Great to hear. Let's move forward then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating Clad in ROOT to v1.9!
No description provided.