[v634] Prevent a race condition in fStreamerImpl value #17759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that all other settings are set before the release (i.e. fProperty switching from -1 to another value)
It is re-run if the first time we ran it, it did not have the full information (i.e. no dictionary nor any interpreter info; this happens for forward classes and STL collections).
pcanal
added
in:Core Libraries
in:Dictionaries
experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #17714.
TClassobjects that do not have a dictionary and do not have interpreter info (this happens forwarded classes and in some cases STL collection) do not have enough information for a final value of their "Properties" and thusTClass::Propertyis set for them to re-run at each invocations. In addition the start of thePropertycalculation was to resetfStreamerImplto the default. Consequently if 1 thread executePropertywhile the other is readingfStreamerImpl, the 2nd one will get an incorrect value.This fixes the problem seen at cms-sw/cmssw#47287 (comment)
This fixes #17753 for v6-34-00-patches.