[Minuit2] Code improvements #17869
Merged
[Minuit2] Code improvements #17869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 4d 1h 41m 36s ⏱️ Results for commit 6c88925. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
minuit2_dev
branch
2 times, most recently
from
ada5b51 to
a8024ce
Compare
As suggested by the comment in the documentation.
Remove unused and controversial `X_pos` and `X_neg` functions from the MnParabola. Also, reduce the documentation a bit because it was too verbose for what the class represents.
The `MnTiny` class was a tiny class that was only used inside `MnMachinePrecision`.
lmoneta
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some TODOs in the Minuit 2 code and also improve in other places, explained further in the commit description.