[ntuple] Split primary and auxiliary models in RNTupleJoinProcessor::CreateJoin
#17936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 5d 2h 14m 13s ⏱️ For more details on these failures, see this check. Results for commit 5666021. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Mar 11, 2025
enirolf
force-pushed
the
ntuple-processor-join-model
branch
2 times, most recently
from
cc09ee6 to
1c01b4e
Compare
enirolf
changed the title
RNTupleJoinProcessor::CreateRNTupleJoinProcessor::CreateJoin
enirolf
force-pushed
the
ntuple-processor-join-model
branch
from
1c01b4e to
af05f1e
Compare
hahnjo
reviewed
Mar 17, 2025
enirolf
force-pushed
the
ntuple-processor-join-model
branch
2 times, most recently
from
435ae83 to
be24fe8
Compare
hahnjo
reviewed
Mar 18, 2025
enirolf
force-pushed
the
ntuple-processor-join-model
branch
from
be24fe8 to
1965191
Compare
hahnjo
approved these changes
Mar 18, 2025
silverweed
reviewed
Mar 20, 2025
enirolf
force-pushed
the
ntuple-processor-join-model
branch
from
1965191 to
29540c8
Compare
To reflect the interface changes introduced in rev d5b4931, instead of a single list of models (one per primary/auxiliary ntuple), a distinction is made between the models of the primary and auxiliary ntuples. Same as before, internally they are combined into one singular model used by the processor.
enirolf
force-pushed
the
ntuple-processor-join-model
branch
from
29540c8 to
5666021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reflect the interface changes introduced in #17964, instead of a single list of models (one per primary/auxiliary ntuple), a distinction is made between the models of the primary and auxiliary ntuples.
Same as before, internally they are combined into one singular model used by the processor. This model has to have the schemas of auxiliary RNTuples as untyped record fields, where the name of the record field is the name of the RNTuple.
A new addition is the added support for partial model specification in the list of auxiliary models. This means that users can pass a null pointer in the position of the corresponding ntuple, and then only for that ntuple, the processor will infer the model from the on-disk descriptor.
Helps move forward #17132.