-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ntuple] Split primary and auxiliary models in RNTupleJoinProcessor::CreateJoin
#17936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ntuple] Split primary and auxiliary models in RNTupleJoinProcessor::CreateJoin
#17936
Conversation
Test Results 19 files 19 suites 5d 2h 14m 13s ⏱️ For more details on these failures, see this check. Results for commit 5666021. ♻️ This comment has been updated with latest results. |
cc09ee6
to
1c01b4e
Compare
RNTupleJoinProcessor::Create
RNTupleJoinProcessor::CreateJoin
1c01b4e
to
af05f1e
Compare
435ae83
to
be24fe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final comment when looking at the code again; we probably want to test a mixture of bare and non-bare models...
be24fe8
to
1965191
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! (should have a second approval)
1965191
to
29540c8
Compare
To reflect the interface changes introduced in rev d5b4931, instead of a single list of models (one per primary/auxiliary ntuple), a distinction is made between the models of the primary and auxiliary ntuples. Same as before, internally they are combined into one singular model used by the processor.
29540c8
to
5666021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To reflect the interface changes introduced in #17964, instead of a single list of models (one per primary/auxiliary ntuple), a distinction is made between the models of the primary and auxiliary ntuples.
Same as before, internally they are combined into one singular model used by the processor. This model has to have the schemas of auxiliary RNTuples as untyped record fields, where the name of the record field is the name of the RNTuple.
A new addition is the added support for partial model specification in the list of auxiliary models. This means that users can pass a null pointer in the position of the corresponding ntuple, and then only for that ntuple, the processor will infer the model from the on-disk descriptor.
Helps move forward #17132.