Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception safety of RDataSource range processing #17975

Merged

Conversation

vepadulano
Copy link
Member

Create an internal RAII struct to manage the calls to the initialization and finalization routines for the nodes of the computation graphs and the data source.

Part 7 of N for #17895

Create an internal RAII struct to manage the calls to the initialization and
finalization routines for the nodes of the computation graphs and the data
source.
Copy link

Test Results

    18 files      18 suites   5d 1h 35m 40s ⏱️
 2 726 tests  2 722 ✅ 0 💤 4 ❌
47 377 runs  47 373 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit eee10cb.

Copy link
Contributor

@martamaja10 martamaja10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Vincenzo!

@vepadulano vepadulano merged commit 2fbb680 into root-project:master Mar 13, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants