Skip to content

[RF] New PDF: gaussian with double sided exponential tails #17976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 14, 2025
Merged

[RF] New PDF: gaussian with double sided exponential tails #17976

merged 10 commits into from
Jun 14, 2025

Conversation

ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented Mar 12, 2025 •
edited by dpiparo
Loading

This Pull request:

Changes or fixes:

Fixes https://its.cern.ch/jira/browse/ROOT-8093

It's a simpler alternative to RooCrystalBall with potentially less instabilities

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

ferdymercury
ferdymercury commented Mar 12, 2025
View reviewed changes
@ferdymercury ferdymercury requested a review from hageboeck March 12, 2025 22:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2025 •
edited
Loading

Test Results

    19 files      19 suites   3d 7h 48m 37s ⏱️
 2 812 tests  2 812 ✅ 0 💤 0 ❌
51 926 runs  51 926 ✅ 0 💤 0 ❌

Results for commit 69b6d9f.

♻️ This comment has been updated with latest results.

@mpuccio
Copy link

mpuccio commented Mar 13, 2025

Hello! Thanks a lot for this, it is extremely useful. About the naming: this distribution has been used in ALICE since well before the paper from Souvik Das, see for instance https://www.worldscientific.com/doi/epdf/10.1142/S0217751X14300440 figure 42 and some code implementation here that was published in 2015. Just to say that it might be fine to just call it for what it is and avoid name attributions.

ferdymercury
ferdymercury commented Mar 13, 2025
View reviewed changes
dpiparo
dpiparo reviewed Mar 31, 2025
View reviewed changes
ferdymercury
ferdymercury commented Mar 31, 2025
View reviewed changes
@ferdymercury ferdymercury added this to the 6.36.00 milestone Apr 15, 2025
@ferdymercury ferdymercury modified the milestones: 6.36.00, 6.38.00 Apr 23, 2025
@ferdymercury
[RF] New PDF: gaussian with double sided exponential tails
4a36987 
It's a simpler alternative too RooCrystalBall with potentially less instabilities

Fixes https://its.cern.ch/jira/browse/ROOT-8093

[RF] assert for devON avoid warning

[RF] Rename generically as suggested by mpuccio

[RF] Rename RooGaussExpTailDas.h to RooGaussExpTails.h

[RF] Rename RooGaussExpTailDas.cxx to RooGaussExpTails.cxx

[RF] multiply instead of divide

Thanks dpiparo

[skip-ci] mention in release notes new PDF
@ferdymercury
Copy link
Collaborator Author

gentle ping @guitargeek

guitargeek
guitargeek reviewed Jun 13, 2025
View reviewed changes
guitargeek
guitargeek reviewed Jun 13, 2025
View reviewed changes
guitargeek
guitargeek reviewed Jun 13, 2025
View reviewed changes
guitargeek
guitargeek reviewed Jun 13, 2025
View reviewed changes
guitargeek
guitargeek reviewed Jun 13, 2025
View reviewed changes
guitargeek
guitargeek reviewed Jun 13, 2025
View reviewed changes
guitargeek
guitargeek reviewed Jun 13, 2025
View reviewed changes
guitargeek
guitargeek reviewed Jun 13, 2025
View reviewed changes
guitargeek
guitargeek requested changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Only a few change requests to follow the RooFit conventions 🙂

ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
ferdymercury
ferdymercury commented Jun 14, 2025
View reviewed changes
@ferdymercury ferdymercury requested a review from guitargeek June 14, 2025 11:39
guitargeek
guitargeek approved these changes Jun 14, 2025
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this initiative!

@guitargeek guitargeek merged commit b77a042 into root-project:master Jun 14, 2025
23 of 24 checks passed
@ferdymercury ferdymercury deleted the dasexp branch June 14, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpiparo dpiparo dpiparo left review comments

@guitargeek guitargeek guitargeek approved these changes

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

@hageboeck hageboeck Awaiting requested review from hageboeck

Assignees

@guitargeek guitargeek

Labels
None yet
Projects
None yet
Milestone
6.38.00
Development

Successfully merging this pull request may close these issues.
4 participants
@ferdymercury @mpuccio @guitargeek @dpiparo