Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurrious auto parsing when looking up a TClass #17994

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pcanal
Copy link
Member

@pcanal pcanal commented Mar 13, 2025

This fixes #17992

Technically the fix is in commit 3812e5e

However analysis of the surrounding code showed that

  • one of the code path was missing a call to PostLoadCheck (74a7abb)
  • the code could be simplified a tad bit.

pcanal added 5 commits March 13, 2025 20:19
At this point, if `cl` was found it was from a simple `FindObject` on the list class
which guarantees that the name is already normalized
If a library was loaded, the alias for a class were also loaded and a non normalized name might lead to a match.
If we skip this check, then the next step will normalized the name and check for typedef inside the name (if
it is a template instance name) and if the name are not found as is, it may lead to loading the header file.

ie. this fixes root-project#17992 and cms-sw/cmssw#47470
@pcanal pcanal added this to the 6.36.00 milestone Mar 13, 2025
@pcanal pcanal requested a review from vepadulano March 13, 2025 20:28
@pcanal pcanal self-assigned this Mar 13, 2025
@pcanal pcanal requested a review from dpiparo as a code owner March 13, 2025 20:28
Copy link

Test Results

    20 files      20 suites   5d 9h 38m 34s ⏱️
 2 729 tests  2 729 ✅ 0 💤 0 ❌
52 696 runs  52 696 ✅ 0 💤 0 ❌

Results for commit c5ea439.

Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philippe for this important fix. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Spurrious auto parsing when looking up a TClass
2 participants