Fix spurrious auto parsing when looking up a TClass#17994
Merged
pcanal merged 5 commits intoroot-project:masterfrom Mar 22, 2025
Merged
Fix spurrious auto parsing when looking up a TClass#17994pcanal merged 5 commits intoroot-project:masterfrom
pcanal merged 5 commits intoroot-project:masterfrom
Conversation
At this point, if `cl` was found it was from a simple `FindObject` on the list class which guarantees that the name is already normalized
If a library was loaded, the alias for a class were also loaded and a non normalized name might lead to a match. If we skip this check, then the next step will normalized the name and check for typedef inside the name (if it is a template instance name) and if the name are not found as is, it may lead to loading the header file. ie. this fixes root-project#17992 and cms-sw/cmssw#47470
This completes 9a42237
Test Results 20 files 20 suites 5d 9h 38m 34s ⏱️ Results for commit c5ea439. |
dpiparo
approved these changes
Mar 18, 2025
Member
dpiparo
left a comment
dpiparo
left a comment
There was a problem hiding this comment.
Thanks Philippe for this important fix. LGTM.
This was referenced Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #17992
Technically the fix is in commit 3812e5e
However analysis of the surrounding code showed that