Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Use C++17 for mac14 to speedup building and testing #18016

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

[ci] Use C++17 for mac14 to speedup building and testing #18016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/root-ci.yml
View file
Original file line number Diff line number Diff line change
@@ -100,7 +100,7 @@ jobs:
overrides: ["LLVM_ENABLE_ASSERTIONS=On", "builtin_zlib=ON"]
- platform: mac14
arch: X64
overrides: ["LLVM_ENABLE_ASSERTIONS=On", "CMAKE_CXX_STANDARD=20"]
overrides: ["LLVM_ENABLE_ASSERTIONS=On"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference in speed between C++20 and C++17?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is huge. Timing measurement still running, but I'll report on what I see on my system.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.reddit.com/r/cpp/comments/o94gvz/what_happened_with_compilation_times_in_c20/?rdt=59968

- platform: mac15
arch: ARM64
overrides: ["LLVM_ENABLE_ASSERTIONS=On", "CMAKE_CXX_STANDARD=20"]