[Minuit2] Performance and thread safety improvements plus refactoring #18018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
commented
Mar 16, 2025
| @@ -83,6 +83,8 @@ HessianGradientCalculator::DeltaGradient(const MinimumParameters &par, const Fun | |||
| unsigned int startElementIndex = mpiproc.StartElementIndex(); | |||
| unsigned int endElementIndex = mpiproc.EndElementIndex(); | |||
|
|
|||
| MnFcnCaller fcnCaller{fFcn}; | |||
There was a problem hiding this comment.
This will be a performance improvement when using strategy==2, where the HessianGradientCalculator is used.
Test Results 18 files 18 suites 4d 16h 48m 46s ⏱️ Results for commit c3ece06. ♻️ This comment has been updated with latest results. |
This makes the code easier to understand, because it is not obfuscated with the virtual type whether the transformation is done or not. For the user of these classes, the only difference was anyway the constructor signature. Now, both constructors are unified in the MnFcn class, and `MnUserFcn.h` is kept as a backwards compatibility header with an alias `using MnUserFcn = MnFcn`.
This class can simply be replaced by using `std::function`, and actually it is not even used anywhere.
The MnSeedGenerator now does this internally.
Just like the input vector `x` needs to be replicated per thread, the function evaluator needs to be instantiated per thread too since it caches the transformed parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit descriptions.