Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF][RS] Fix StandardHistFactoryPlotsWithCategories tutorial #18020

Merged
merged 1 commit into from
Mar 19, 2025
+27 −68
Merged

[RF][RS] Fix StandardHistFactoryPlotsWithCategories tutorial #18020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 15 additions & 37 deletions tutorials/roofit/roostats/StandardHistFactoryPlotsWithCategories.C
View file
Original file line number Diff line number Diff line change
@@ -176,14 +176,14 @@ void StandardHistFactoryPlotsWithCategories(const char *infile = "", const char
RooPlot *frame = obs->frame();
frame->SetYTitle(var->GetName());
data->plotOn(frame, MarkerSize(1));
var->setVal(0);
const double value = var->getVal();
mc->GetPdf()->plotOn(frame, LineWidth(1.));
var->setVal(1);
var->setVal(value + var->getError());
mc->GetPdf()->plotOn(frame, LineColor(kRed), LineStyle(kDashed), LineWidth(1));
var->setVal(-1);
var->setVal(value - var->getError());
mc->GetPdf()->plotOn(frame, LineColor(kGreen), LineStyle(kDashed), LineWidth(1));
frameList.push_back(frame);
var->setVal(0);
var->setVal(value);
}

} else {
@@ -223,57 +223,35 @@ void StandardHistFactoryPlotsWithCategories(const char *infile = "", const char
Double_t normCount =
data->sumEntries(Form("%s==%s::%s", channelCat->GetName(), channelCat->GetName(), catName.c_str()));

if (strcmp(var->GetName(), "Lumi") == 0) {
cout << "working on lumi" << endl;
var->setVal(w->var("nominalLumi")->getVal());
var->Print();
} else {
var->setVal(0);
}
// remember the nominal value
const double value = var->getVal();

// w->allVars().Print("v");
// mc->GetNuisanceParameters()->Print("v");
// pdftmp->plotOn(frame,LineWidth(2.));
// mc->GetPdf()->plotOn(frame,LineWidth(2.),Slice(*channelCat,catName.c_str()),ProjWData(*data));
// pdftmp->plotOn(frame,LineWidth(2.),Slice(*channelCat,catName.c_str()),ProjWData(*data));
normCount = pdftmp->expectedEvents(*obs);
pdftmp->plotOn(frame, LineWidth(2.), Normalization(normCount, RooAbsReal::NumEvent));

if (strcmp(var->GetName(), "Lumi") == 0) {
cout << "working on lumi" << endl;
var->setVal(w->var("nominalLumi")->getVal() + 0.05);
var->Print();
} else {
var->setVal(nSigmaToVary);
}
pdftmp->plotOn(frame, LineWidth(2.), Normalization(normCount, RooAbsReal::NumEvent)); // nominal

var->setVal(value + nSigmaToVary * var->getError());
// pdftmp->plotOn(frame,LineColor(kRed),LineStyle(kDashed),LineWidth(2));
// mc->GetPdf()->plotOn(frame,LineColor(kRed),LineStyle(kDashed),LineWidth(2.),Slice(*channelCat,catName.c_str()),ProjWData(*data));
// pdftmp->plotOn(frame,LineColor(kRed),LineStyle(kDashed),LineWidth(2.),Slice(*channelCat,catName.c_str()),ProjWData(*data));
normCount = pdftmp->expectedEvents(*obs);
pdftmp->plotOn(frame, LineWidth(2.), LineColor(kRed), LineStyle(kDashed),
Normalization(normCount, RooAbsReal::NumEvent));

if (strcmp(var->GetName(), "Lumi") == 0) {
cout << "working on lumi" << endl;
var->setVal(w->var("nominalLumi")->getVal() - 0.05);
var->Print();
} else {
var->setVal(-nSigmaToVary);
}
Normalization(normCount, RooAbsReal::NumEvent)); // +n sigma

var->setVal(value - nSigmaToVary * var->getError());
// pdftmp->plotOn(frame,LineColor(kGreen),LineStyle(kDashed),LineWidth(2));
// mc->GetPdf()->plotOn(frame,LineColor(kGreen),LineStyle(kDashed),LineWidth(2),Slice(*channelCat,catName.c_str()),ProjWData(*data));
// pdftmp->plotOn(frame,LineColor(kGreen),LineStyle(kDashed),LineWidth(2),Slice(*channelCat,catName.c_str()),ProjWData(*data));
normCount = pdftmp->expectedEvents(*obs);
pdftmp->plotOn(frame, LineWidth(2.), LineColor(kGreen), LineStyle(kDashed),
Normalization(normCount, RooAbsReal::NumEvent));
Normalization(normCount, RooAbsReal::NumEvent)); // -n sigma

// set them back to normal
if (strcmp(var->GetName(), "Lumi") == 0) {
cout << "working on lumi" << endl;
var->setVal(w->var("nominalLumi")->getVal());
var->Print();
} else {
var->setVal(0);
}
var->setVal(value);

frameList.push_back(frame);

43 changes: 12 additions & 31 deletions tutorials/roofit/roostats/StandardHistFactoryPlotsWithCategories.py
View file
Original file line number Diff line number Diff line change
@@ -154,14 +154,14 @@ def StandardHistFactoryPlotsWithCategories(
frame = obs.frame()
frame.SetYTitle(var.GetName())
data.plotOn(frame, MarkerSize(1))
var.setVal(0)
value = var.getVal()
mc.GetPdf().plotOn(frame, LineWidth(1))
var.setVal(1)
var.setVal(value + var.getError());
mc.GetPdf().plotOn(frame, LineColor(kRed), LineStyle(kDashed), LineWidth(1))
var.setVal(-1)
var.setVal(value - var.getError());
mc.GetPdf().plotOn(frame, LineColor(kGreen), LineStyle(kDashed), LineWidth(1))
frameList.append(frame)
var.setVal(0)
var.setVal(value)

else:
channelCat = simPdf.indexCat()
@@ -204,12 +204,8 @@ def StandardHistFactoryPlotsWithCategories(

normCount = data.sumEntries(cut)

if str(var.GetName()) == "Lumi":
print(f"working on lumi")
var.setVal(w.var("nominalLumi").getVal())
var.Print()
else:
var.setVal(0)
# remember the nominal value
value = var.getVal()

# w.allVars().Print("v")
# mc.GetNuisanceParameters().Print("v")
@@ -231,14 +227,9 @@ def StandardHistFactoryPlotsWithCategories(
# instead, we have to use obstmp
# normCount = pdftmp.expectedEvents(RooArgSet(obstmp)) #doesn´t work properly
normCount = pdftmp.expectedEvents(obstmp)
pdftmp.plotOn(frame, ROOT.RooFit.Normalization(normCount, ROOT.RooAbsReal.NumEvent), LineWidth=2)
pdftmp.plotOn(frame, ROOT.RooFit.Normalization(normCount, ROOT.RooAbsReal.NumEvent), LineWidth=2) # nominal

if str(var.GetName()) == "Lumi":
print(f"working on lumi")
var.setVal(w.var("nominalLumi").getVal() + 0.05)
var.Print()
else:
var.setVal(nSigmaToVary)
var.setVal(value + nSigmaToVary * var.getError())

# pdftmp.plotOn(frame,LineColor(kRed),LineStyle(kDashed),LineWidth(2))
# mc.GetPdf().plotOn(frame,LineColor(kRed),LineStyle(kDashed),LineWidth(2.),Slice(channelCat,catName.c_str()),ProjWData(data))
@@ -250,14 +241,9 @@ def StandardHistFactoryPlotsWithCategories(
LineWidth=2,
LineColor="r",
LineStyle="--",
)
) # +n sigma

if str(var.GetName()) == "Lumi":
print(f"working on lumi")
var.setVal(w.var("nominalLumi").getVal() - 0.05)
var.Print()
else:
var.setVal(-nSigmaToVary)
var.setVal(value - nSigmaToVary * var.getError())

# pdftmp.plotOn(frame,LineColor(kGreen),LineStyle(kDashed),LineWidth(2))
# mc.GetPdf().plotOn(frame,LineColor(kGreen),LineStyle(kDashed),LineWidth(2),Slice(channelCat,catName.c_str()),ProjWData(data))
@@ -269,15 +255,10 @@ def StandardHistFactoryPlotsWithCategories(
LineWidth=2,
LineColor="g",
LineStyle="--",
)
) # -n sigma

# set them back to normal
if str(var.GetName()) == "Lumi":
print(f"working on lumi")
var.setVal(w.var("nominalLumi").getVal())
var.Print()
else:
var.setVal(0)
var.setVal(value)

frameList.append(frame)