[Math] Move TimingScope to ROOT::Math::Util
#18021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 20 files 20 suites 5d 14h 21m 45s ⏱️ Results for commit 4dcdf15. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
Mar 17, 2025
Move TimingScope to `ROOT::Math::Util` in MathCore to avoid code duplication while at the same time not introducing new dependencies (MathCore is the only dependency that Minuit2 is allowed to have because of the standalone build possibility).
guitargeek
force-pushed
the
timing_scope
branch
from
56040a3 to
4dcdf15
Compare
lmoneta
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move TimingScope to
ROOT::Math::Utilin MathCore to avoid code duplication while at the same time not introducing new dependencies (MathCore is the only dependency that Minuit2 is allowed to have because of the standalone build possibility).This follows up on previous comments by @lmoneta.