[ntuple] Move RPageInfo(Extended) up one level of nesting #18024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are now inner classes of RClusterDescriptor directly rather than of RClusterDescriptor::RPageRange
enirolf
requested changes
Mar 17, 2025
Test Results 20 files 20 suites 5d 16h 11m 56s ⏱️ Results for commit a50d770. ♻️ This comment has been updated with latest results. |
enirolf
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline with @jblomer and @hahnjo, we decided to move these nested classes up one level, mostly for simplification.
Checklist: