[tmva][sofie] Fix compilation warnings due to missing override #18030
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove also some warning happening by variable re-declaration when not using Session in generated code - fix issue in operator Range when using verbose mode
Test Results 20 files 20 suites 5d 9h 37m 43s ⏱️ For more details on these failures, see this check. Results for commit b273f0e. |
sanjibansg
approved these changes
Mar 18, 2025
Comment on lines
+348
to
+350
| // // no need to declare xcol tensor since it is added as intermediate tensor | ||
| // if (!fUseSession) | ||
| // out << SP << fType << " tensor_" << fNX << "_f[" << fShapeW[0] * fShapeW[1] * fAttrKernelShape[0] * fAttrKernelShape[1] << "] = {0};\n"; |
There was a problem hiding this comment.
maybe we can remove the commented code if it's of no use any longer
Comment on lines
+404
to
+409
| // no need to declare xcol tensor since it is added as intermediate tensor | ||
| // if (!fUseSession) { | ||
| // out << SP << fType << " tensor_" << fNX << "_xcol[" | ||
| // << fShapeX[1] * fAttrKernelShape[0] * fAttrKernelShape[1] * fAttrKernelShape[2] * oDepth * oHeight * oWidth | ||
| // << "] = {0};\n"; | ||
| // } |
There was a problem hiding this comment.
same suggestion on removing the commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.