Skip to content

[tmva][sofie] Fix compilation warnings due to missing override #18030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

lmoneta
Copy link
Member

@lmoneta lmoneta commented Mar 18, 2025

No description provided.

Copy link

github-actions bot commented Mar 18, 2025

Test Results

    20 files      20 suites   5d 13h 10m 31s ⏱️
 2 726 tests  2 726 ✅ 0 💤 0 ❌
52 591 runs  52 591 ✅ 0 💤 0 ❌

Results for commit 512217b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@sanjibansg sanjibansg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the change, just some minor suggestions on removing commented code.

 - remove also some warning happening by variable re-declaration when not using Session in generated code
 - fix issue in operator Range when using verbose mode
@lmoneta lmoneta force-pushed the tmva_fix_warnings branch from b273f0e to 512217b Compare March 18, 2025 18:20
@lmoneta lmoneta merged commit 3701ae2 into root-project:master Mar 19, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants